Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check: verify ino and dev of overlayfs files in /proc/pid/maps #2320

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

avagin
Copy link
Member

@avagin avagin commented Dec 29, 2023

Check that the file device and inode shown in /proc/pid/maps match values returned by stat(2).

@avagin avagin marked this pull request as draft December 29, 2023 05:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

Attention: Patch coverage is 62.50000% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 70.20%. Comparing base (cb39c62) to head (4bf16da).

❗ Current head 4bf16da differs from pull request most recent head 8e83b7a. Consider uploading reports for the commit 8e83b7a to get more accurate results

Files Patch % Lines
criu/cr-check.c 62.50% 42 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           criu-dev    #2320      +/-   ##
============================================
- Coverage     70.21%   70.20%   -0.01%     
============================================
  Files           132      132              
  Lines         34372    34484     +112     
============================================
+ Hits          24134    24210      +76     
- Misses        10238    10274      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avagin avagin force-pushed the overlayfs_maps branch 3 times, most recently from 8e4d6db to e33e313 Compare December 30, 2023 07:49
@avagin avagin marked this pull request as ready for review January 2, 2024 06:32
@Snorch
Copy link
Member

Snorch commented Jan 30, 2024

Looks good.

minor nits:

  • note "clang-format: Possible coding style problem" warnings, alignment may be improved
  • error messages like pr_perror("syscallname"); may be rewritten in "Unable to syscallname smth." style

Do we want to add it to kdat?

@avagin avagin force-pushed the overlayfs_maps branch 3 times, most recently from c98229d to 8e83b7a Compare February 25, 2024 00:10
Copy link

A friendly reminder that this PR had no activity for 30 days.

@rst0git rst0git added no-auto-close Don't auto-close as a stale issue and removed stale-pr labels Mar 26, 2024
Check that the file device and inode shown in /proc/pid/maps match
values returned by stat(2).

Signed-off-by: Andrei Vagin <avagin@gmail.com>
@avagin avagin merged commit 7aa8ec4 into checkpoint-restore:criu-dev Apr 10, 2024
28 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-auto-close Don't auto-close as a stale issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants