plugin/amdgpu: Don't print error for "No such process" during resume #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the late stages of restore, each process being resumed gets an ioctl call to KFD_CRIU_OP_RESUME. If the process has no kfd process info, this call with fail with -ESRCH. This is normal behaviour, so we shouldn't print an error message for it. Signed-off-by: David Francis <David.Francis@amd.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## criu-dev #2340 +/- ##
=========================================
Coverage 70.56% 70.57%
=========================================
Files 132 132
Lines 33619 33619
=========================================
+ Hits 23723 23726 +3
+ Misses 9896 9893 -3 ☔ View full report in Codecov by Sentry. |
Snorch
reviewed
Feb 2, 2024
| @@ -1999,7 +1999,10 @@ int amdgpu_plugin_resume_devices_late(int target_pid) | |||
| args.op = KFD_CRIU_OP_RESUME; | |||
| pr_info("Calling IOCTL to start notifiers and queues\n"); | |||
| if (kmtIoctl(fd, AMDKFD_IOC_CRIU_OP, &args) == -1) { | |||
| pr_perror("restore late ioctl failed"); | |||
| if (errno == ESRCH) | |||
| pr_info("Pid %d has no kfd process info\n", target_pid); | |||
There was a problem hiding this comment.
We don't print error here, but we still return -1, I feel that this behavior is kind of inconsistent? Do I miss something?
There was a problem hiding this comment.
criu "ignores" this error code: https://github.com/checkpoint-restore/criu/blob/criu-dev/criu/cr-restore.c#L2487
I think @Snorch is right, we have to return 0 in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the late stages of restore, each process being resumed gets an ioctl call to KFD_CRIU_OP_RESUME. If the process has no kfd process info, this call with fail with -ESRCH. This is normal behaviour, so we shouldn't print an error message for it.