Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: try to fix broken docker test #2371

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

adrianreber
Copy link
Member

Upgrade to 22.04 base image and skip pinning docker to a certain version.

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.74%. Comparing base (cb39c62) to head (24b8254).

❗ Current head 24b8254 differs from pull request most recent head 83e357e. Consider uploading reports for the commit 83e357e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           criu-dev    #2371      +/-   ##
============================================
+ Coverage     70.21%   70.74%   +0.53%     
============================================
  Files           132      134       +2     
  Lines         34372    32950    -1422     
============================================
- Hits          24134    23312     -822     
+ Misses        10238     9638     -600     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Upgrade to 22.04 base image and use the existing version of docker.

Signed-off-by: Adrian Reber <areber@redhat.com>
Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rst0git
Copy link
Member

rst0git commented Mar 25, 2024

@adrianreber Would it make sense to also upgrade the workflow for Podman to 22.04?

@adrianreber
Copy link
Member Author

@adrianreber Would it make sense to also upgrade the workflow for Podman to 22.04?

This PR tries to fix a broken CI test, so I would not do it in this PR. In another PR, sure, why not.

@avagin avagin merged commit f7b2e63 into checkpoint-restore:criu-dev Mar 25, 2024
37 of 39 checks passed
@adrianreber adrianreber deleted the 2024-03-24-docker branch March 26, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants