irmap: duplicate string in irmap_scan_path_add #2415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate string in irmap_scan_path_add, otherwise it will free before parsing next configuration input. Signed-off-by: Liu Hua <weldonliu@tencent.com>
|
A friendly reminder that this PR had no activity for 30 days. |
avagin
reviewed
Jul 2, 2024
| @@ -500,7 +500,7 @@ int irmap_scan_path_add(char *path) | |||
| return -1; | |||
| } | |||
|
|
|||
| o->ir->path = path; | |||
| o->ir->path = strdup(path); | |||
There was a problem hiding this comment.
strdup can return NULL and we need to handle this case.
|
Merged: fac8d64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate string in irmap_scan_path_add, otherwise it will free before parsing next configuration input.