Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @kruppel @kev71187 @jeremyd @Sasso
tl;dr: Our healthcheck has been sending us an empty string with proxy protocol header prepended. So this PR is to disable proxy protocol on ELB since we are not utilizing it
To work around Kubernetes's S-NAT'd incoming node port traffic in order to preserve source IP, many production deployments use proxy protocol, but since we set up ELB right to be HTTP, this hasn't been our problem, since it'd set
X-Forwarded-For
.Though we have enabled it by default, and it was causing our apps having lots of parse errors, since our apps don't understand how proxy protocol works.
The below is the packets we're getting as healthchecks to our apps:
And it's supposed to be empty strings for puma to ignore it.