-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc for MethodLength #11474
Milestone
Comments
We should show in new examples the effect that both block and single line comments have on this check depending on |
Can I work on this |
Sure, please leave a comment "I am on it", and send PR. Pay special attention to comment at #11474 (comment) pertaining to changes made at #11312 |
I am on it |
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 8, 2022
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 8, 2022
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 9, 2022
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 9, 2022
Can I work on this issue? |
No, there is already PR for this issue Issue #11523 |
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 9, 2022
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 9, 2022
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 10, 2022
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 10, 2022
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 10, 2022
kaungmyat-htet
added a commit
to kaungmyat-htet/checkstyle
that referenced
this issue
Apr 11, 2022
strkkk
pushed a commit
that referenced
this issue
Apr 12, 2022
fix is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://checkstyle.org/config_sizes.html#MethodLength
Add example for each existing config to show what code is ok and what code cause violation.
A good example is https://checkstyle.org/config_naming.html#AbstractClassName.
Look at referenced commits of #5832, to see what and how should be changed in code.
Please play with module/check by means of https://checkstyle.org/cmdline.html to understand how it works.
PLEASE READ https://github.com/checkstyle/checkstyle/wiki/Good-practice-on-how-to-update-examples
The text was updated successfully, but these errors were encountered: