Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Pitest suppression for SeparatorWrapCheck #12430

Closed
arinmodi opened this issue Nov 19, 2022 · 6 comments
Closed

Resolve Pitest suppression for SeparatorWrapCheck #12430

arinmodi opened this issue Nov 19, 2022 · 6 comments

Comments

@arinmodi
Copy link
Contributor

arinmodi commented Nov 19, 2022

Parent #12341

Kill The Mutation :

<mutation unstable="false">
<sourceFile>SeparatorWrapCheck.java</sourceFile>
<mutatedClass>com.puppycrawl.tools.checkstyle.checks.whitespace.SeparatorWrapCheck</mutatedClass>
<mutatedMethod>visitToken</mutatedMethod>
<mutator>org.pitest.mutationtest.engine.gregor.mutators.experimental.ArgumentPropagationMutator</mutator>
<description>replaced call to com/puppycrawl/tools/checkstyle/utils/CodePointUtil::trim with argument</description>
<lineContent>final int[] substringAfterToken = CodePointUtil.trim(</lineContent>
</mutation>

For SeparatorWrapCheck

@arinmodi
Copy link
Contributor Author

I am on it

@arinmodi
Copy link
Contributor Author

Any Maintainers, please guide me if am at wrong path

@arinmodi
Copy link
Contributor Author

hardcoded mutation means, I have to replace the line specified in mutation with suggested line given as description ?

Am I correct ?

@nrmancuso
Copy link
Member

It looks like this and following trim are suspect, this code was previously copy pasted from another check: https://github.com/checkstyle/checkstyle/pull/180/files#

hardcoded mutation means, I have to replace the line specified in mutation with suggested line given as description ?

@arinmodi Yes, all tests should still pass if you have hardcoded the correct mutation.

@nrmancuso
Copy link
Member

@arinmodi please always reference parent issue at #12341 in issue description

arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 20, 2022
arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 20, 2022
arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 21, 2022
arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 21, 2022
arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 21, 2022
arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 22, 2022
arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 22, 2022
arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 22, 2022
arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 22, 2022
arinmodi added a commit to arinmodi/checkstyle that referenced this issue Nov 22, 2022
@rnveach
Copy link
Member

rnveach commented Nov 22, 2022

Fix was merged

@rnveach rnveach closed this as completed Nov 22, 2022
@rnveach rnveach added this to the 10.5 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants