Issue #13012: Resolve Path contains invalid character #13862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romani
requested changes
Oct 10, 2023
| check.setHeaderFile(new URI("test://bad")); | ||
| final String nonAscii = "\u00e6\u00f8\u00e5"; | ||
| final URI uri = new URI("test://bad" + nonAscii); | ||
| check.setHeaderFile(uri); | ||
|
|
There was a problem hiding this comment.
Please create new test method.
We need to make sure all existing tests continue to work as before.
| try { | ||
| final String[] expected = CommonUtil.EMPTY_STRING_ARRAY; | ||
| verifyWithInlineConfigParser(configInDirWithNonAsciiCharacters.toString(), expected); | ||
| assertWithMessage("Test should fail if exception was not thrown").fail(); |
There was a problem hiding this comment.
Hmm, checkstyle should work well according to issue, please explain why you expect exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #13012