Issue #206: Fix incorrect filter condition for binary search

[MEZk]

#208

@romani

This looks like the issue. Binary search returns >= 0 if it exists in array and < 0 on where it should be inserted into array if it doesn't exist. It doesn't guarantee a result of -1 all the time.
Condition should be checking >= 0 instead of != -1.

Yes, that was the problem.

issue checkstyle/checkstyle#3437
one more : checkstyle/checkstyle#3892
has label "new feature" but it is not present in releasenotes after 7.6, that forced me to create 7.6.1 release instead of 7.7 .
TODO: investigate a reason of missed "new feature" group in release notes of 7.6.1 - checkstyle.sourceforge.net/releasenotes.html#Release_7.6.1

Fixed.

one more problem - checkstyle/checkstyle#3329 does not have label and build is not failed

Fixed.

link to all closed "new feature" issues - https://github.com/checkstyle/checkstyle/issues?q=is%3Aissue+label%3A%22new+feature%22+is%3Aclosed+sort%3Aupdated-desc

Here is the xdoc.xml which was generated starting from tag checkstyle-6.12. As you can see there are 48 issues in New group.

Program args to check:
-localRepoPath /checkstyle -startRef checkstyle-6.12 -githubAuthToken *********************************** -releaseNumber 8 -generateXdoc

I do not know why TeamCity is not happy this time.

[rnveach]

I do not know why TeamCity is not happy this time.

TC problems are because they upgraded, and the upgrade is not working correctly and it is breaking everything.

[MEZk]

@rnveach

TC problems are because they upgraded, and the upgrade is not working correctly and it is breaking everything.

It's a pity. This is not the first time (