launch_diff: upgraded util to not rely on maven plugin #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To show how #273 should be done, I updated my own script to not rely on maven anymore.
It uses the pure Checkstyle CLI with no updates to patch-diff-report-tool needed and not extra dependencies.
install
commands where changed topackage
now.github
support was removed, should just rely ongit
.master
as if it was a different branch.Here is an example run of the differences for the same PR and config:
Maven: http://rveach.no-ip.org/checkstyle/regression/reports/149/
CLI: http://rveach.no-ip.org/checkstyle/regression/reports/150/
Only real difference is counts for number of files being processed overall. Maven was restricting us to Java only file types while CLI pulls in all files.
No changes in difference reporting. No changes to internal web page acting as interface for user to program.
Slight speed increase as we don't need to copy large quantity of files around (twice) or try to minimize those files. Less output to console too (263kb versus 103kb).
An external change will be needed to switch to using CLI full time. Excludes uses a wildcard match while CLI excludes must be a pattern matching. So all excludes will need to be updated in scope of #273 .