Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for a lot of Check to make their Sonar config up to implementation, update for rules.xml file (UT validation) #28

Closed
romani opened this issue Dec 13, 2016 · 9 comments
Labels
Milestone

Comments

@romani
Copy link
Member

romani commented Dec 13, 2016

@romani
Copy link
Member Author

romani commented Dec 31, 2016

list of available tokens is still not validated, not violation after update to checkstyle 7.4 for NoWhitespaceAfter, WhitespaceAfter

@romani
Copy link
Member Author

romani commented Jan 4, 2017

Interesting project https://github.com/startupheroes/startupheroes-checkstyle/tree/master/startupheroes-sonar-file-generator-maven-plugin , unfortunately we can not use/copy their code but we can try to use them as binary

@ozlmulg
Copy link

ozlmulg commented Jan 4, 2017

@romani We updated our license file (startupheroes-checkstyle) You can use our codes if you want. Good works.

@rnveach
Copy link
Member

rnveach commented Feb 24, 2017

checkstyle.propertiestchecks needs to be validated for tokens, as it contains a duplicate of acceptable and default tokens. It should also be validated for default value for other properties as they contain that too.

@rnveach
Copy link
Member

rnveach commented Mar 17, 2017

from my previous comment. Sonar displays default values in a gray font below the property description if the rules.xml specifies something other than an empty string.
We probably shouldn't display the defaults in checkstyle.propertiestchecks if sonar will display the gray text for us.
You can see this for tokens in SuppressWarningsCheck and IllegalTokenTextCheck.

@rnveach
Copy link
Member

rnveach commented Mar 17, 2017

@romani As I am waiting for my current PR to be finalized, I am going to split this issue up into multiple so it is clear what needs to be done.

@rnveach
Copy link
Member

rnveach commented Mar 17, 2017

Rules cardinality validation was added to Issue #87

@romani romani changed the title UT validation for rules.xml against checkstyle's all Checks Update for a lot of Check to make their Sonar config up to implementation, update for rules.xml file (UT validation) Mar 18, 2017
@romani
Copy link
Member Author

romani commented Mar 18, 2017

@rnveach , please close this issue is you split it completely.
Such huge issue is not good to keep.

@rnveach
Copy link
Member

rnveach commented Mar 18, 2017

I believe I did split everything

@rnveach rnveach closed this as completed Mar 18, 2017
@romani romani added this to the 3.7 milestone Mar 18, 2017
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants