Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding paths to TaskContext and updating all tasks to use it #430

Merged
merged 2 commits into from
May 27, 2020
Merged

Adding paths to TaskContext and updating all tasks to use it #430

merged 2 commits into from
May 27, 2020

Conversation

carakessler
Copy link
Collaborator

This completes the work outlined in this issue #400

Essentially, adding paths to the TaskContext and updating all existing tasks and tests to operate on globs (if they are passed in) instead of the entire app.

@carakessler carakessler added the internal Internal infrastructure work label May 23, 2020
@carakessler carakessler requested a review from scalvert May 23, 2020 02:05
@carakessler carakessler linked an issue May 23, 2020 that may be closed by this pull request
Adding support to checkup to operate on specific paths #400
Closed
scalvert
scalvert requested changes May 26, 2020
View reviewed changes
packages/test-helpers/src/checkup-fixturify-project.ts Outdated Show resolved Hide resolved
packages/core/src/types/util.ts Outdated Show resolved Hide resolved
packages/cli/__tests__/get-paths-test.ts Outdated Show resolved Hide resolved
packages/cli/__tests__/get-paths-test.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/run.ts Outdated Show resolved Hide resolved
packages/core/package.json Outdated Show resolved Hide resolved
packages/core/src/searchers/file-searcher.ts Outdated Show resolved Hide resolved
packages/test-helpers/src/get-task-context.ts Outdated Show resolved Hide resolved
packages/test-helpers/src/filter-result-data.ts Outdated Show resolved Hide resolved
@scalvert scalvert merged commit 8f88c8b into master May 27, 2020
@scalvert scalvert deleted the paths branch May 27, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scalvert scalvert scalvert approved these changes

Assignees
No one assigned
Labels
internal Internal infrastructure work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding support to checkup to operate on specific paths
2 participants
@carakessler @scalvert