Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make helpers available from controller and views #4

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Make helpers available from controller and views #4

merged 1 commit into from
Apr 20, 2021

Conversation

bouk
Copy link
Contributor

@bouk bouk commented Apr 19, 2021

Here I'm adding the right modules and hooks so application helpers are available from twirp controllers.

@bouk bouk requested a review from es April 19, 2021 18:18
@@ -7,7 +7,8 @@ def ping
end

def ping_render
response = RPC::DummyAPI::PingResponse.new(double_name: request.name * 2)
url = rails_twirp_engine_url
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does rails_twirp_engine_url come from?

Copy link
Contributor Author

@bouk bouk Apr 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a regular rails url helper, see routes.rb

Copy link
Contributor

@es es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM

@bouk bouk merged commit fba5d1e into main Apr 20, 2021
@bouk bouk deleted the helpers branch April 20, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants