-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rust to v1.37.0 #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
force-pushed
the
afiune/upgrade-rust
branch
from
August 26, 2019 22:44
4404387
to
4de9b26
Compare
afiune
requested review from
markan,
tas50,
tyler-ball,
jonsmorrow and
marcparadise
August 26, 2019 22:45
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/upgrade-rust
branch
from
August 26, 2019 22:51
4de9b26
to
c24d931
Compare
marcparadise
approved these changes
Aug 29, 2019
jaymalasinha
approved these changes
Aug 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/upgrade-rust
branch
from
August 29, 2019 20:48
23de680
to
cb07549
Compare
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
I have disabled the
I am going to try to fix the pipeline on a different PR! |
afiune
force-pushed
the
afiune/upgrade-rust
branch
from
August 29, 2019 23:51
5c4016b
to
1b4a08b
Compare
Signed-off-by: Salim Afiune <afiune@chef.io>
afiune
force-pushed
the
afiune/upgrade-rust
branch
from
August 30, 2019 00:02
1b4a08b
to
1403584
Compare
marcparadise
approved these changes
Aug 30, 2019
I'm okay with disabling the pipeline test for now, but could you open an issue to track it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Salim Afiune afiune@chef.io