Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rust to v1.37.0 #65

Merged
merged 7 commits into from
Aug 30, 2019
Merged

Upgrade rust to v1.37.0 #65

merged 7 commits into from
Aug 30, 2019

Conversation

afiune
Copy link

@afiune afiune commented Aug 26, 2019

Signed-off-by: Salim Afiune afiune@chef.io

@afiune afiune changed the title Upgrade rust to v1..37.0 Upgrade rust to v1.37.0 Aug 26, 2019
Signed-off-by: Salim Afiune <afiune@chef.io>
Copy link
Contributor

@jaymalasinha jaymalasinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Salim Afiune added 3 commits August 29, 2019 14:18
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
Salim Afiune added 2 commits August 29, 2019 16:20
Signed-off-by: Salim Afiune <afiune@chef.io>
Signed-off-by: Salim Afiune <afiune@chef.io>
@afiune
Copy link
Author

afiune commented Aug 29, 2019

I have disabled the job.feature tests since I couldn't troubleshoot the pipeline but they all run fine locally!

➜  delivery-cli git:(afiune/upgrade-rust) ✗ chef exec bundle exec cucumber features/job.feature
Feature: job

  Background:                                                            # features/job.feature:3
      # `git merge` and `git reset` need to be mocked here because the specific
      # merge and reset commands rely on the existence of an upstream remote
    Given I set the environment variables to:                            # aruba-0.14.6/lib/aruba/cucumber/environment.rb:17
      | variable     | value |
      | MERGE_MOCKED | true  |
      | RESET_MOCKED | true  |
    And I clean up the ruby env so I can run other ruby bins like ChefDK # features/support/steps.rb:161
    And I am in the "delivery-cli-init" git repo                         # features/support/steps.rb:132
    And a file named ".delivery/cli.toml" with:                          # aruba-0.14.6/lib/aruba/cucumber/file.rb:23
      """
        git_port = "2828"
        pipeline = "master"
        user = "cukes"
        server = "delivery.mycompany.com"
        enterprise = "skunkworks"
        organization = "engineering"
      """

  Scenario: With all information specified in the configuration file                                                                                                                           # features/job.feature:22
    When I successfully run `delivery job verify syntax --project phoenix_project --for master --patchset 1 --change-id 822b0eee-5cfb-4b35-9331-c9bc6b49bdb2 --change username/feature/branch` # aruba-0.14.6/lib/aruba/cucumber/command.rb:27
    Then the exit status should be 0                                                                                                                                                           # aruba-0.14.6/lib/aruba/cucumber/command.rb:277
    And the output should contain:                                                                                                                                                             # aruba-0.14.6/lib/aruba/cucumber/command.rb:205
      """
      Chef Client finished
      """
    And "git clone ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project ." should be run                                                                  # features/support/steps.rb:190
    And 'git fetch origin _reviews/master/username/feature/branch/1' should be run                                                                                                             # features/support/steps.rb:190
    And 'git remote add delivery ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project' should not be run                                                  # features/support/steps.rb:195

  Scenario: Specifying the patchset branch explicitly                                                                                                                             # features/job.feature:33
    When I successfully run `delivery job verify syntax --project phoenix_project --for master --change-id 822b0eee-5cfb-4b35-9331-c9bc6b49bdb2 --branch username/feature/branch` # aruba-0.14.6/lib/aruba/cucumber/command.rb:27
    Then the exit status should be 0                                                                                                                                              # aruba-0.14.6/lib/aruba/cucumber/command.rb:277
    And the output should contain:                                                                                                                                                # aruba-0.14.6/lib/aruba/cucumber/command.rb:205
      """
      Chef Client finished
      """
    And "git clone ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project ." should be run                                                     # features/support/steps.rb:190
    And 'git fetch origin username/feature/branch' should be run                                                                                                                  # features/support/steps.rb:190
    And 'git remote add delivery ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project' should not be run                                     # features/support/steps.rb:195

  Scenario: A repo that has failing tests                                                                                                                            # features/job.feature:44
    Given I have a repository with failing tests                                                                                                                     # features/support/steps.rb:171
    When I run `delivery job verify syntax --project phoenix_project --for master --change-id 822b0eee-5cfb-4b35-9331-c9bc6b49bdb2 --branch username/feature/branch` # aruba-0.14.6/lib/aruba/cucumber/command.rb:13
    Then the exit status should not be 0                                                                                                                             # aruba-0.14.6/lib/aruba/cucumber/command.rb:277
    And the output should contain:                                                                                                                                   # aruba-0.14.6/lib/aruba/cucumber/command.rb:205
      """
      Chef Client failed
      """
    And "git clone ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project ." should be run                                        # features/support/steps.rb:190
    And 'git fetch origin username/feature/branch' should be run                                                                                                     # features/support/steps.rb:190
    And 'git remote add delivery ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project' should not be run                        # features/support/steps.rb:195

  Scenario: Executing a local job                                                                                                             # features/job.feature:56
    When I run `delivery job verify syntax -l`                                                                                                # aruba-0.14.6/lib/aruba/cucumber/command.rb:13
    Then the output should contain:                                                                                                           # aruba-0.14.6/lib/aruba/cucumber/command.rb:205
      """
      Chef Client finished
      """
    And 'git remote add delivery ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project' should not be run # features/support/steps.rb:195
    And 'git remote add delivery ssh://you@local@localhost:2828/local/workstation/delivery-cli-init' should not be run                        # features/support/steps.rb:195
    And "git clone ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project ." should not be run             # features/support/steps.rb:195
    And 'git fetch origin username/feature/branch' should not be run                                                                          # features/support/steps.rb:195
    And 'git fetch origin master' should be run                                                                                               # features/support/steps.rb:190
    And the exit status should be 0                                                                                                           # aruba-0.14.6/lib/aruba/cucumber/command.rb:277

  Scenario: Real job triggering; this command is exactly as we trigger jobs in Chef Automate                                                                                                                                                                                                                                                                             # features/job.feature:69
    Given I am in a blank workspace                                                                                                                                                                                                                                                                                                                                      # features/support/steps.rb:155
    When I run `delivery job build syntax --server delivery.mycompany.com --user cukes --ent skunkworks --org engineering --project phoenix_project --for master --change-id 80983bb0-5cb5-4ec9-a5f1-b023d4c14d69 --shasum 88782dfd260a2b8277b100ba5192c7131b81aa0a --git-url ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project` # aruba-0.14.6/lib/aruba/cucumber/command.rb:13
    Then the output should contain:                                                                                                                                                                                                                                                                                                                                      # aruba-0.14.6/lib/aruba/cucumber/command.rb:205
      """
      Chef Client finished
      """
    And "git clone ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project ." should be run                                                                                                                                                                                                                                            # features/support/steps.rb:190
    And 'git fetch origin' should be run                                                                                                                                                                                                                                                                                                                                 # features/support/steps.rb:190
    And 'git remote add delivery ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project' should not be run                                                                                                                                                                                                                            # features/support/steps.rb:195
    And the exit status should be 0                                                                                                                                                                                                                                                                                                                                      # aruba-0.14.6/lib/aruba/cucumber/command.rb:277

  Scenario: Real job triggering; specifying a2 mode works                                                                                                                                                                                                                                                                                                                          # features/job.feature:81
    Given I am in a blank workspace                                                                                                                                                                                                                                                                                                                                                # features/support/steps.rb:155
    When I run `delivery job build syntax --server delivery.mycompany.com --user cukes --ent skunkworks --org engineering --project phoenix_project --for master --change-id 80983bb0-5cb5-4ec9-a5f1-b023d4c14d69 --shasum 88782dfd260a2b8277b100ba5192c7131b81aa0a --git-url ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project --a2-mode` # aruba-0.14.6/lib/aruba/cucumber/command.rb:13
    Then the exit status should be 0                                                                                                                                                                                                                                                                                                                                               # aruba-0.14.6/lib/aruba/cucumber/command.rb:277

  Scenario: Real job triggering; If you try to run a job outside of the git_repo and                                                                                                                                                                                                                                                           # features/job.feature:86
          also without specifying a `--project` flag. We must fail.
    Given I am in a blank workspace                                                                                                                                                                                                                                                                                                            # features/support/steps.rb:155
    When I run `delivery job build syntax --server delivery.mycompany.com --user cukes --ent skunkworks --org engineering --for master --change-id 80983bb0-5cb5-4ec9-a5f1-b023d4c14d69 --shasum 88782dfd260a2b8277b100ba5192c7131b81aa0a --git-url ssh://cukes@skunkworks@delivery.mycompany.com:2828/skunkworks/engineering/phoenix_project` # aruba-0.14.6/lib/aruba/cucumber/command.rb:13
    Then the output should contain:                                                                                                                                                                                                                                                                                                            # aruba-0.14.6/lib/aruba/cucumber/command.rb:205
      """
      Cannot find a .git/config file. Run 'git init' in your project root to initialize it
      """
    And the exit status should not be 0                                                                                                                                                                                                                                                                                                        # aruba-0.14.6/lib/aruba/cucumber/command.rb:277

7 scenarios (7 passed)
69 steps (69 passed)
0m43.045s

I am going to try to fix the pipeline on a different PR!

Signed-off-by: Salim Afiune <afiune@chef.io>
@marcparadise
Copy link
Contributor

I'm okay with disabling the pipeline test for now, but could you open an issue to track it?

@afiune afiune merged commit b643829 into master Aug 30, 2019
@chef-ci chef-ci deleted the afiune/upgrade-rust branch August 30, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants