AWS instance updates #3041
AWS instance updates #3041
Conversation
| @@ -18,7 +18,7 @@ module "single_local_inplace_upgrade" { | |||
| vpc = "${var.environment}" | |||
| platform = "ubuntu-16.04" | |||
| key_name = "cd-infrastructure" | |||
| instance_type = "m4.large" | |||
| instance_type = "m5.large" | |||
There was a problem hiding this comment.
does this mean we will lose the data that is currently on these instances?
There was a problem hiding this comment.
No, I already resized them to m5.large this morning during the maintenance window. During the update I just restarted the instance, so you did not loose any data
| @@ -70475,6 +70475,24 @@ const ( | |||
| // InstanceTypeT22xlarge is a InstanceType enum value | |||
| InstanceTypeT22xlarge = "t2.2xlarge" | |||
|
|
|||
| // InstanceTypeT3Micro is a InstanceType enum value | |||
| InstanceTypeT3Micro = "t3.micro" | |||
There was a problem hiding this comment.
Are these changes you made yourself or are they from the upstream aws/aws-sdk-go package? If the former, we need to chat about how we are going to manage these patches as we typically do not change code in the vendor directory. If the latter, we will mant to make sure we get go.mod and go.sum updated to account for what version these are in.
There was a problem hiding this comment.
I made those manually since I was changing the type to t3.micro. I will revert this file.
jaymalasinha
force-pushed
the
jsinha/instance_updates
branch
2 times, most recently
from
b067948
to
11bafd6
Compare
stevendanna
force-pushed
the
jsinha/instance_updates
branch
from
11bafd6
to
9c84407
Compare
…inplace_upgrade senarios As requested in https://github.com/chef/release-engineering/issues/962 Signed-off-by: Jaymala Sinha <jsinha@chef.io>
Signed-off-by: Jaymala Sinha <jsinha@chef.io>
tduffield
force-pushed
the
jsinha/instance_updates
branch
from
9c84407
to
6018a06
Compare
🔩 Description: What code changed, and why?
Re-size and remove AWS instances
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
📷 Screenshots, if applicable