Remove v1/v2 vestiges in ui #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msorens
added
automate-auth
chore
auth-team
blakestier
reviewed
Mar 27, 2020
blakestier
approved these changes
Mar 27, 2020
bcmdarroch
approved these changes
Mar 27, 2020
Signed-off-by: michael sorens <msorens@chef.io>
Signed-off-by: michael sorens <msorens@chef.io>
It was returning a false positive due to missing a `detectChanges`. Signed-off-by: michael sorens <msorens@chef.io>
Signed-off-by: michael sorens <msorens@chef.io>
Signed-off-by: michael sorens <msorens@chef.io>
msorens
force-pushed
the
ms/remove-v1-v2-vestiges-in-ui
branch
from
070c6b1
to
e678031
Compare
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Follow-up to #2722, removes the last vestiges of v1 and v2 in the UI.
Review by following the commits for specifics.
⛓️ Related Resources
#2722
👍 Definition of Done
No more v1 and v2 in the UI. Really.
👟 How to Build and Test the Change
No changes in functionality.
Also no changes in tests really; just one test deleted.
So the only way to test the change is to grep v1 and v2... and then sort through the barrage of output.
✅ Checklist