Fix logic error that prevented multi-select dropdowns from closing properly #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susanev
added
auth-team
susanev
approved these changes
May 12, 2020
msorens
approved these changes
May 12, 2020
| @@ -74,11 +74,10 @@ export class ResourceDropdownComponent implements OnInit, OnChanges { | |||
| if (!this.active) { // opening | |||
| this.filterValue = ''; | |||
| this.filteredResources = this.resourcesInOrder; | |||
| this.active = !this.active; | |||
There was a problem hiding this comment.
Because this is now used only in a single case, I think it improves clarity to do this:
Suggested change
| this.active = !this.active; | |
| this.active = true; |
(Just like there is this.active = false; on L95.)
|
it seems that #3533 is not fixed with this, so there may still be a click outside functionality issue that can be solved in that other issue. but toggle works great now, thank you!! |
…operly toggleDropdown was calling closeDropdown, which set active to false, but then toggleDropdown flipped the value of active for both the open and close case, incorretly setting active back to true after closeDropdown was called. Signed-off-by: Tyler Cloke <tylercloke@gmail.com>
tylercloke
force-pushed
the
tc/dropdown-fail
branch
from
848b5fd
to
528b715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
toggleDropdownwas callingcloseDropdown, which setactiveto false, but thentoggleDropdownflipped the value ofactivefor both the open and close case, incorrectly settingactiveback to true aftercloseDropdownwas called.👟 How to Build and Test the Change
Create a project then go to a multi-select dropdown (say in teams create modal).
Click on the dropdown and it will open.
Now, do any of the following and it should close properly:
✅ Checklist