Client Runs Delete check boxes not showing up. #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lance Finfrock <lfinfrock@chef.io>
Signed-off-by: Lance Finfrock <lfinfrock@chef.io>
lancewf
commented
May 27, 2020
| @@ -16,7 +16,7 @@ <h2 id="confirm-delete-modal-label" class="status-modal-heading">Warning</h2> | |||
| <strong>{{nodesSelectedForDelete.size}} node{{ nodesSelectedForDelete.size | i18nPlural: pluralMapping }}</strong>. | |||
| </p> | |||
| <p>This action can not be undone.</p> | |||
| <chef-button primary caution (click)="closeModal(true)"> | |||
| <chef-button class="delete-button-confirm" primary caution (click)="closeModal(true)"> | |||
There was a problem hiding this comment.
Added to allow the cypress test to find this control.
There was a problem hiding this comment.
In other places, I believe we've used data-cy for that.
There was a problem hiding this comment.
lancewf
commented
May 27, 2020
| @@ -374,7 +374,7 @@ export class ClientRunsComponent implements OnInit, OnDestroy { | |||
| this.authorizedChecker = new AuthorizedChecker(this.store); | |||
| this.authorizedChecker.setPermissions([ | |||
| { | |||
| endpoint: '/ingest/events/chef/node-multiple-deletes', | |||
| endpoint: '/api/v0/ingest/events/chef/node-multiple-deletes', | |||
srenatus
approved these changes
May 28, 2020
| @@ -16,7 +16,7 @@ <h2 id="confirm-delete-modal-label" class="status-modal-heading">Warning</h2> | |||
| <strong>{{nodesSelectedForDelete.size}} node{{ nodesSelectedForDelete.size | i18nPlural: pluralMapping }}</strong>. | |||
| </p> | |||
| <p>This action can not be undone.</p> | |||
| <chef-button primary caution (click)="closeModal(true)"> | |||
| <chef-button class="delete-button-confirm" primary caution (click)="closeModal(true)"> | |||
There was a problem hiding this comment.
In other places, I believe we've used data-cy for that.
vjeffrey
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Fixing a bug where admin users were not provided the checkboxes to delete missing nodes. The problem was the API path used was incorrect. The incorrect path that was being used was "/ingest/events/chef/node-multiple-deletes", but it was correct path is "/api/v0/ingest/events/chef/node-multiple-deletes".
⛓️ Related Resources
#3802
👟 How to Build and Test the Change
build components/automate-ui-devproxy && start_all_services && start_automate_ui_backgroundsend_chef_run_exampleui_logs✅ Checklist
📷 Screenshots, if applicable