Fixing Event Feed chef server filter bug #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lance Finfrock <lfinfrock@chef.io>
lancewf
added
bug 🐛
vjeffrey
reviewed
Jun 25, 2020
| @@ -137,7 +137,7 @@ func ConvertParamToActionBackend(parameter string) string { | |||
| switch parameter { | |||
| case "organization": | |||
| return backend.ActionOrganization | |||
| case "source_fqdn": | |||
| case "source_fqdn", "chef_server": | |||
There was a problem hiding this comment.
im curious -- why not also include "service_hostname" here? is that not another alias?
There was a problem hiding this comment.
The "service_hostname" term is the real value that we use to filter on. The backend.ActionSourceFQDN equals "service_hostname".
If we do want to add that term as part of our API we could add it here. That term seemed to me to be internal use only. Maybe I should remove it from the unit test 🤔
There was a problem hiding this comment.
👍 i just didn't know what the term was
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Fixing event feed chef-server filtering. The problem was that the UI was using the term 'chef_server' but the only valid terms were ''source_fqdn' or 'service_hostname'. The solution was to add 'chef_server' as an alias.
👍 Definition of Done
Filtering the event feed with a chef-server works.
👟 How to Build and Test the Change
build components/config-mgmt-service && start_all_servcieschef_load_nodes 100chef_load_actions 100✅ Checklist