Remove default initialization of radio button #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That was causing the "saved" state of the radio button to be true, regardless of its actual value, thereby rendering the mechanism that recognizes a change ineffective. Signed-off-by: michael sorens <msorens@chef.io>
msorens
added
auth-team
msorens
changed the title
susanev
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Once you save a token as Inactive, you could not reactivate it. The system always thought "Active" was the saved state, so switching to Active actually disables the "Save" button instead of enabling it.
Cause: The default state of the radio button was being initialized to true, regardless of its actual value, thereby rendering the mechanism that recognizes a change ineffective.
⛓️ Related Resources
NA
👍 Definition of Done
You can reactivate an Inactive token in the UI.
👟 How to Build and Test the Change
Navigate to Settings >> Tokens >> (token) >> Details
Use a token that is inactive. If you do not have one, open the details, make it inactive, save, then go back to the token list, and re-open the details.
✅ Checklist