Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rule name in the notification instead of the id. #4331

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

samshinde
Copy link
Contributor

Signed-off-by: samshinde ashinde@chef.io

🔩 Description: What code changed, and why?

After creating a rule, In the Notification bar, it shows the id of the particular rule, not the name so changed it to name.

⛓️ Related Resources

#1130

👍 Definition of Done

Rule name displayed in the notification instead of the id.

👟 How to Build and Test the Change

  1. visit the Settings >>Projects page
  2. create Projects >> create Rule in a particular projects
STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

✅ Checklist

📷 Screenshots, if applicable

rule-notify

@samshinde samshinde added automate-auth ui automate-ui iamv2 This issue or pull request applies to iamv2 work for Automate ux auth-team anything that needs to be on the auth team board labels Sep 14, 2020
@samshinde samshinde self-assigned this Sep 14, 2020
@netlify
Copy link

netlify bot commented Sep 14, 2020

Deploy preview for chef-automate ready!

Built with commit f08b918

https://deploy-preview-4331--chef-automate.netlify.app

@samshinde samshinde force-pushed the Amol/createRule_notification_changes branch 3 times, most recently from 4f53641 to dc12bff Compare September 16, 2020 13:03
samshinde added 2 commits September 24, 2020 17:27
Signed-off-by: samshinde <ashinde@chef.io>
Signed-off-by: samshinde <ashinde@chef.io>
@samshinde samshinde force-pushed the Amol/createRule_notification_changes branch from dc12bff to f08b918 Compare September 24, 2020 11:58
@susanev susanev merged commit a688cd9 into master Sep 24, 2020
@susanev susanev deleted the Amol/createRule_notification_changes branch September 24, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth-team anything that needs to be on the auth team board automate-auth automate-ui iamv2 This issue or pull request applies to iamv2 work for Automate ui ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants