Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved Add Users button overlaps with the user table. #4361

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

samshinde
Copy link
Contributor

Signed-off-by: samshinde ashinde@chef.io

🔩 Description: What code changed, and why?

The Add Users button overlaps with the user table on the add-users-to-team modal and changed the height of the table to get a space between them.

⛓️ Related Resources

#2752

👍 Definition of Done

Add user button overlaps with the user table so added space between them.

👟 How to Build and Test the Change

  1. start Automate + UI
  2. navigate to https://a2-dev.test/settings/users and create several users
  3. navigate to https://a2-dev.test/settings/teams/editors/add-users
  4. you should be able to see the overlap of the buttons with the last row of users
STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

✅ Checklist

📷 Screenshots, if applicable

Screenshot from 2020-09-22 15-58-45

Signed-off-by: samshinde <ashinde@chef.io>
@samshinde samshinde added bug 🐛 Something isn't working ui automate-ui auth-team anything that needs to be on the auth team board needs-triage labels Sep 22, 2020
@samshinde samshinde self-assigned this Sep 22, 2020
@netlify
Copy link

netlify bot commented Sep 22, 2020

Deploy preview for chef-automate ready!

Built with commit 8367629

https://deploy-preview-4361--chef-automate.netlify.app

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susanev susanev requested a review from a team September 22, 2020 14:36
Copy link
Contributor

@tarablack01 tarablack01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@susanev susanev merged commit afbd560 into master Sep 22, 2020
@susanev susanev deleted the Amol/user_table_changes branch September 22, 2020 15:15
@msorens
Copy link
Contributor

msorens commented Sep 22, 2020

Have we checked that this does not occur for any other similar pages?

@samshinde
Copy link
Contributor Author

Have we checked that this does not occur for any other similar pages?

@msorens Yes, I have checked the settings tab in which we have the same pop-up in these pages: Projects-> Create Rule, Policies-> Add Member, and there is no overlapping issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth-team anything that needs to be on the auth team board automate-ui bug 🐛 Something isn't working ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants