Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ids column in Policies and Roles List #4393

Merged
merged 3 commits into from
Feb 1, 2021

Conversation

samshinde
Copy link
Contributor

@samshinde samshinde commented Oct 6, 2020

Signed-off-by: samshinde ashinde@chef.io

🔩 Description: What code changed, and why?

In the Roles and policy list tables added a column for ID.

⛓️ Related Resources

#4036

👍 Definition of Done

Added a column for ID on the policy list and role list pages.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command ```
### :white_check_mark: Checklist

- [ ] I have read the [CONTRIBUTING document](https://github.com/chef/automate/blob/master/CONTRIBUTING.md).
- [ ] Tests added/updated?
- [ ] Docs added/updated?
- [ ] All commits have been signed-off for the [Developer Certification of Origin](https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco).

### :camera: Screenshots, if applicable

@samshinde samshinde added automate-auth ui automate-ui ux auth-team anything that needs to be on the auth team board labels Oct 6, 2020
@samshinde samshinde self-assigned this Oct 6, 2020
@netlify
Copy link

netlify bot commented Oct 6, 2020

Deploy preview for chef-automate processing.

Building with commit 62f53f9

https://app.netlify.com/sites/chef-automate/deploys/6012862a5721f10007db7dc6

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srenatus
Copy link
Contributor

srenatus commented Oct 7, 2020

@samshinde samshinde force-pushed the Amol/project_and_roles_changes branch 2 times, most recently from 15c2cac to 9e32a4c Compare October 8, 2020 06:12
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is the wrong way to fix the tests, I'm afraid. Can you alter the assertions to match what's in the policy list, and add one for the policy IDs to be displayed, please?

Copy link
Contributor

@msorens msorens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as I mentioned several days ago, it is important not to squash your changes into a single commit, especially when making changes responding to reviewer feedback.

@samshinde
Copy link
Contributor Author

@srenatus @msorens Could you please help me out on this as I have done the primary analysis but we didn't find the file which will solve the error. If you have any opinion on that, please suggest.

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note on how to adapt the tests! :)

@samshinde samshinde force-pushed the Amol/project_and_roles_changes branch from 9e32a4c to 53ce007 Compare November 18, 2020 04:26
@msorens
Copy link
Contributor

msorens commented Dec 10, 2020

This PR still needs to add tests for the ID column as srenatus indicated above.

Copy link
Contributor

@msorens msorens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the requested test changes have been done, so I am approving, but since this is so old, though, I think it would be prudent to rebase before merging to see if all the tests are still good.

@msorens msorens changed the title Added Ids column in Policies and Roles List. Added Ids column in Policies and Roles List Jan 28, 2021
samshinde added 3 commits January 28, 2021 15:07
Signed-off-by: samshinde <ashinde@chef.io>
Signed-off-by: samshinde <ashinde@chef.io>
Signed-off-by: samshinde <ashinde@chef.io>
@samshinde samshinde force-pushed the Amol/project_and_roles_changes branch from 0b37bca to 62f53f9 Compare January 28, 2021 09:38
@msorens msorens merged commit dbd81bd into master Feb 1, 2021
@msorens msorens deleted the Amol/project_and_roles_changes branch February 1, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants