Hiding nginx from the response header #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lance Finfrock <lfinfrock@chef.io>
|
Deploy preview for chef-automate processing. Building with commit fd7536d https://app.netlify.com/sites/chef-automate/deploys/5f862e5e4577b80007c6ff66 |
added 3 commits
October 12, 2020 15:44
Signed-off-by: Lance Finfrock <lfinfrock@chef.io>
Added the headers-more-nginx-module to the nginx build. Also add the line 'more_set_headers 'server: ' that removes the server nginx field from the response. Signed-off-by: Lance Finfrock <lfinfrock@chef.io>
lancewf
force-pushed
the
lancewf/hide_nginx
branch
from
5985966
to
fd7536d
Compare
lancewf
commented
Oct 13, 2020
| @@ -0,0 +1,89 @@ | |||
|
|
|||
There was a problem hiding this comment.
This file is needed in the nginx.conf file
lancewf
commented
Oct 13, 2020
| @@ -106,6 +106,8 @@ http { | |||
|
|
|||
| {{#each cfg.frontend_tls as |tls| ~}} | |||
| server { | |||
| more_set_headers 'server: '; | |||
There was a problem hiding this comment.
This removes the server line from the response.
lancewf
commented
Oct 13, 2020
| @@ -5,4 +5,4 @@ exec 2>&1 | |||
|
|
|||
| source {{pkg.svc_config_path}}/render-certs.sh | |||
|
|
|||
| exec {{pkgPathFor "core/nginx"}}/bin/nginx -c {{pkg.svc_config_path}}/nginx.conf | |||
| exec nginx -c {{pkg.svc_config_path}}/nginx.conf | |||
There was a problem hiding this comment.
nginx is in the path now.
lancewf
commented
Oct 13, 2020
| --with-http_slice_module \ | ||
| --with-cc-opt="${CFLAGS}" \ | ||
| --with-ld-opt="${LDFLAGS}" \ | ||
| --add-module=${HAB_CACHE_SRC_PATH}/headers-more-nginx-module-${headers_more_version} |
There was a problem hiding this comment.
Adding the headers-more module
lancewf
commented
Oct 13, 2020
| pkg_origin=chef | ||
| pkg_version="0.1.0" | ||
| pkg_description="internal and external load balancer and reverse proxy for Automate 2.0" |
There was a problem hiding this comment.
Most of the changes here were copied from here https://github.com/chef-base-plans/nginx/blob/master/plan.sh
lancewf
changed the title
danielsdeleo
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Nginx should not be exposed in the response header for automate-ui requests.
This change is building Nginx with the headers-more module. This module allows removing the server field from the response.
⛓️ Related Resources
#4403
👟 How to Build and Test the Change
start_all_servicesrebuild components/automate-load-balancer/✅ Checklist
📷 Screenshots, if applicable