Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test inspec profile URLs #4429

Merged
merged 3 commits into from
Nov 6, 2020
Merged

Conversation

alexpop
Copy link
Contributor

@alexpop alexpop commented Nov 5, 2020

🔩 Description: What code changed, and why?

Remove dependency on Victoria's test inspec profiles.

Signed-off-by: Alex Pop <apop@chef.io>
Signed-off-by: Alex Pop <apop@chef.io>
@netlify
Copy link

netlify bot commented Nov 5, 2020

Deploy preview for chef-automate ready!

Built with commit 26d78bd

https://deploy-preview-4429--chef-automate.netlify.app

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@@ -110,7 +110,7 @@ func (suite *GatewayTestSuite) TestLicenseUsageNodes() {
Name: "my job for aws-api node manager",
Tags: []*common.Kv{},
Type: "exec",
Profiles: []string{"https://github.com/vjeffrey/try-inspec-aws-profile/archive/master.tar.gz"},
Profiles: []string{"https://github.com/chef/automate/raw/master/components/compliance-service/test_data/inspec_profiles/test-aws-profile-2.0.0.tar.gz"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'd be a little safer if this wasn't master, but a commit ref 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, will make the change tomorrow, thank you!

Signed-off-by: Alex Pop <apop@chef.io>
@alexpop alexpop merged commit 3138afe into master Nov 6, 2020
@alexpop alexpop deleted the ap/use-aws-azure-local-profiles branch November 6, 2020 11:27
Copy link
Contributor

@rickmarry rickmarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alexpop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants