Hab studio tech debt #4727
Merged
Hab studio tech debt #4727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details emitted when running `compile_all_protobuf_components`: ``` protoc -I../../components/notifications-service/server/priv \ --go_out=plugins=grpc:./api \ notifications.proto rules.proto server.proto health.proto 2021/02/12 22:17:32 WARNING: Deprecated use of 'go_package' option without a full import path in "notifications.proto", please specify: option go_package = ".;api"; A future release of protoc-gen-go will require the import path be specified. See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information. 2021/02/12 22:17:32 WARNING: Deprecated use of 'go_package' option without a full import path in "rules.proto", please specify: option go_package = ".;api"; A future release of protoc-gen-go will require the import path be specified. See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information. 2021/02/12 22:17:32 WARNING: Deprecated use of 'go_package' option without a full import path in "health.proto", please specify: option go_package = ".;api"; A future release of protoc-gen-go will require the import path be specified. See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information. 2021/02/12 22:17:32 WARNING: Deprecated use of 'go_package' option without a full import path in "server.proto", please specify: option go_package = ".;api"; A future release of protoc-gen-go will require the import path be specified. See https://developers.google.com/protocol-buffers/docs/reference/go-generated#package for more information. ``` Signed-off-by: michael sorens <msorens@chef.io>
Signed-off-by: michael sorens <msorens@chef.io>
Signed-off-by: michael sorens <msorens@chef.io>
|
Deploy preview for chef-automate processing. Building with commit a7ac35a https://app.netlify.com/sites/chef-automate/deploys/602aa96b93e2c200077c83a5 |
msorens
commented
Feb 14, 2021
| describe "check_breaking_for_all_proto_components" <<DOC | ||
| document "check_breaking_for_all_proto_components" <<DOC |
There was a problem hiding this comment.
Problem due to this "typo"
| option go_package = "api"; | ||
| option go_package = ".;api"; |
There was a problem hiding this comment.
Applying fix specified in the warning itself.
Signed-off-by: michael sorens <msorens@chef.io>
danielsdeleo
approved these changes
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Two hab studio fixes included:
(1) Upon entering hab studio, the console output showed this error:
(2) Upon running
compile_all_protobuf_components, the console showed these warnings:⛓️ Related Resources
NA
👍 Definition of Done
Above error and warnings are gone.
👟 How to Build and Test the Change
(1) hab studio enter
(2) compile_all_protobuf_components (inside hab studio)
✅ Checklist