-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FQDN up to 25 characters #4900
FQDN up to 25 characters #4900
Conversation
Signed-off-by: kagarmoe <kgarmoe@chef.io>
Deploy preview for chef-automate ready! Built with commit 112f00c |
@@ -31,7 +31,7 @@ This section describes those settings and how to change them on an existing Chef | |||
|
|||
#### Chef Automate FQDN | |||
|
|||
To change the fully qualified domain name (FQDN) of your Chef Automate installation, create a TOML file that contains the partial configuration: | |||
The maximum size of a customized fully qualified domain name (FQDN) is 25 characters. To change the of your Chef Automate installation, create a TOML file that contains the partial configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lost a subject in there.
The maximum size of a customized fully qualified domain name (FQDN) is 25 characters. To change the of your Chef Automate installation, create a TOML file that contains the partial configuration: | |
The maximum size of a customized fully qualified domain name (FQDN) is 25 characters. To change the FQDN of your Chef Automate installation, create a TOML file that contains the partial configuration: |
@@ -31,7 +31,7 @@ This section describes those settings and how to change them on an existing Chef | |||
|
|||
#### Chef Automate FQDN | |||
|
|||
To change the fully qualified domain name (FQDN) of your Chef Automate installation, create a TOML file that contains the partial configuration: | |||
The maximum size of a customized fully qualified domain name (FQDN) is 25 characters. To change the of your Chef Automate installation, create a TOML file that contains the partial configuration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good guess, but, well, not so much. There is no limit on the size of the whole FQDN string.
The 25-character limit is only after the final dot, so something like this is invalid:
http://www.foo.this-portion-is-probably-too-long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SEAjamieD So 25 characters for the top-level domain?
http://www.foo.this-portion-is-probably-too-long
<scheme>://<subdomain>.<second-level domain>.<top-level domain>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kagarmoe - Correct, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending and update for @msorens comment below, this is good for our needs. Thanks so much!
There is no limit on the size of the whole FQDN string.
The 25-character limit is only after the final dot, so something like this is invalid:
http://www.foo.this-portion-is-probably-too-long
Signed-off-by: kagarmoe <kgarmoe@chef.io>
Signed-off-by: kagarmoe kgarmoe@chef.io
🔩 Description: What code changed, and why?
Define the length of the FQDN in the configurations doc.
Includes some linting cleanup.
⛓️ Related Resources
#4890
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable