Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Read only] Infra node list page UI with search and pagination. #5018

Merged
merged 8 commits into from
May 4, 2021

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented Apr 30, 2021

🔩 Description: What code changed, and why?

We need to add the read-only node list page UI with the search and pagination.

⛓️ Related Resources

#4371

👍 Definition of Done

I have added the new UI for the infra node list page UI (read-only), I have covered below mentioned points.

  • Infra node list page
  • Infra node list with pagination
  • Search infra nodes
  • Cypress specs

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

navigate to `https://a2-dev.test/infrastructure/chef-servers`
add some sample data and then test the changes using tab change

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views

Go to the -->  `infrastructure tab` from the top navigation bar then you can see the `Chef Infra Server`
If you have data then you can see the list of servers 
--> then click to any of the servers --> see the list of org's
--> click to any of org ---> you can see the multiple tabs --> default tab is cookbooks tab 
--> you can see the nodes tab ---> click to nodes tab
--> if nodes are available then you can see the list of nodes with search and pagination.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

node-list.mp4

Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
@netlify
Copy link

netlify bot commented Apr 30, 2021

Deploy preview for chef-automate processing.

Building with commit e324b58

https://app.netlify.com/sites/chef-automate/deploys/608ff6c294378f0007fc6c24

Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Copy link
Contributor

@himanshi-chhabra himanshi-chhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Copy link
Contributor

@SEAjamieD SEAjamieD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job on this 🎉 - my only request would be more unit tests if/when you have the time.

@kalroy kalroy merged commit f2a4af4 into master May 4, 2021
@kalroy kalroy deleted the Vinay/node_list_view branch May 4, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants