-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Read only] Infra node list page UI with search and pagination. #5018
Conversation
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Deploy preview for chef-automate processing. Building with commit e324b58 https://app.netlify.com/sites/chef-automate/deploys/608ff6c294378f0007fc6c24 |
Signed-off-by: Vinay Sharma <vsharma@chef.io>
components/automate-ui/src/app/entities/infra-nodes/infra-nodes.actions.ts
Outdated
Show resolved
Hide resolved
components/automate-ui/src/app/entities/infra-nodes/infra-nodes.requests.ts
Outdated
Show resolved
Hide resolved
components/automate-ui/src/app/modules/infra-proxy/infra-nodes/infra-nodes.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: Vinay Sharma <vsharma@chef.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great job on this 🎉 - my only request would be more unit tests if/when you have the time.
🔩 Description: What code changed, and why?
We need to add the read-only node list page UI with the search and pagination.
⛓️ Related Resources
#4371
👍 Definition of Done
I have added the new UI for the infra node list page UI (read-only), I have covered below mentioned points.
👟 How to Build and Test the Change
To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
node-list.mp4