-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added validation on create pop-up, search bar inside org details #5026
Conversation
Deploy preview for chef-automate processing. Building with commit 0bf891f https://app.netlify.com/sites/chef-automate/deploys/609a4576475ae40008b61cbf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @himanshi-chhabra 🎉
When I placed # at first place in textbox, will not throw error. But in search box, show error. Please find below recording. Validation.mp4 |
...tomate-ui/src/app/modules/infra-proxy/create-client-modal/create-client-modal.component.html
Outdated
Show resolved
Hide resolved
7f4b9c1
to
7b7d59e
Compare
@chaitali-mane Update the changes |
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
f134127
to
0bf891f
Compare
@chaitali-mane i have updated the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me , thanks @himanshi-chhabra
Signed-off-by: Himanshi Chhabra hchhabra@progress.com
🔩 Description: What code changed, and why?
⛓️ Related Resources
#4960
👍 Definition of Done
VALDATION:- Added validation that name can only contain
alphabets
a-z, A-Z,numbers
0-9,Underscore
_,Hyphen
-.👟 How to Build and Test the Change
To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps to reproduce:
1. Click Roles -> Create Role -> add name with
test role
-> show error ->name can only contain 'a-z', 'A-Z', '0-9', '_', '-'.
and create button isdisabled
.2. add name with
test_role-1:::::
-> show error ->name can only contain 'a-z', 'A-Z', '0-9', '_', '-'.
and create button isdisabled
.3. add name with
test_role-1
-> no error.4. Same for others tab.
1. Click Roles -> add text on search bar with
test@role
-> show error ->name can only contain 'a-z', 'A-Z', '0-9', '_', '-'.
and search button isdisabled
.2. add name with
test[role]-1:::::
->no roles available with this name.
3. add name with
test_role-1
-> no error.4. Same for others tab.
role(role-1
-> show error ->name can only contain 'a-z', 'A-Z', '0-9', '_', '-'.
test[role]-1
-> showNot available
.test_role-1
-> no error.✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
name-valid.mp4