Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Nodes Section to the Chef Infra Server #5066

Merged
merged 5 commits into from
May 18, 2021
Merged

Added Nodes Section to the Chef Infra Server #5066

merged 5 commits into from
May 18, 2021

Conversation

dishanktiwari2501
Copy link
Collaborator

@dishanktiwari2501 dishanktiwari2501 commented May 12, 2021 •
edited
Loading

Node Section added to the Chef Infra Server Page

  • View functionality added for the nodes.
  • List of nodes with pagination.
  • Search functionality.
  • Delete functionality.

Reference Link: #4918

@dishanktiwari2501 dishanktiwari2501 added the documentation Anything related to the Automate docs. label May 12, 2021
@netlify
Copy link

netlify bot commented May 12, 2021 •
edited
Loading

Deploy preview for chef-automate processing.

Building with commit cad35eb

https://app.netlify.com/sites/chef-automate/deploys/60a3377b0806df000705887d

kagarmoe
kagarmoe suggested changes May 12, 2021
View reviewed changes
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The discussion of nodes in Chef Infra isn't accurate. I've provided links for you to read more. Please revise that section.

The other comments are smaller stylistic issues.

components/docs-chef-io/content/automate/chef_infra_server.md Outdated Show resolved Hide resolved
components/docs-chef-io/content/automate/chef_infra_server.md Outdated Show resolved Hide resolved
components/docs-chef-io/content/automate/chef_infra_server.md Outdated Show resolved Hide resolved
components/docs-chef-io/content/automate/chef_infra_server.md Outdated Show resolved Hide resolved
components/docs-chef-io/content/automate/chef_infra_server.md Outdated Show resolved Hide resolved
kagarmoe
kagarmoe previously requested changes May 17, 2021
View reviewed changes
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your description of Nodes is still inaccurate.

components/docs-chef-io/content/automate/chef_infra_server.md Outdated Show resolved Hide resolved
@dishanktiwari2501 dishanktiwari2501 dismissed kagarmoe’s stale review May 17, 2021 06:41

Have fixed the description. Updated the md.

IanMadd
IanMadd approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@IanMadd IanMadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-94154164

@dishanktiwari2501 @kalroy
added nodes section to the chef infra server
d9c9275 
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
@dishanktiwari2501 @kalroy
added delete functionality for the node object
c017e25 
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
@dishanktiwari2501 @kalroy
suggestions added
3421540 
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
@dishanktiwari2501 @kalroy
node introduction updated
4c8d074 
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
@dishanktiwari2501 @kalroy
changes made after review
cad35eb 
Signed-off-by: Dishank Tiwari <dtiwari@progress.com>
@kalroy kalroy force-pushed the add-node-functionalities-for-chef-automate branch from 5308b74 to cad35eb Compare May 18, 2021 03:41
@kalroy kalroy merged commit 837c0c6 into master May 18, 2021
@kalroy kalroy deleted the add-node-functionalities-for-chef-automate branch May 18, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMadd IanMadd IanMadd approved these changes

@kagarmoe kagarmoe kagarmoe left review comments

Assignees
No one assigned
Labels
acceptance: verified documentation Anything related to the Automate docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dishanktiwari2501 @kagarmoe @IanMadd @kalroy