Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search bar for Data Bags list page #5069

Merged
merged 3 commits into from
May 18, 2021
Merged

Conversation

chaitali-mane
Copy link
Contributor

@chaitali-mane chaitali-mane commented May 14, 2021

Signed-off-by: Chaitali Mane cmane@progress.com

🔩 Description: What code changed, and why?

Need to add search bar for databags list UI.

⛓️ Related Resources

4657

👍 Definition of Done

I have added changes for the databags list page by adding search bar.

👟 How to Build and Test the Change

STEP 1

inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

navigate to https://a2-dev.test/infrastructure/client-runs
add some sample data and then test the changes using tab change

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views

Go to the infrastructure tab from the top navigation bar then you can see the Chef Server
If you have data then you can see the list of servers --> then click to any of server --> see the list of orgs
--> click to any of org ---> you can see the multiple tabs
Click to any tab from Data Bags
--> Where you can see the search box with search button, when you type something in input and search for that then you will get filtered data bags list.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Chef Automate-da

@netlify
Copy link

netlify bot commented May 14, 2021

Deploy preview for chef-automate processing.

Building with commit a91a081

https://app.netlify.com/sites/chef-automate/deploys/60a11c6df3680600073dc0bc

Signed-off-by: chaitali-mane <cmane@progress.com>
Signed-off-by: chaitali-mane <cmane@progress.com>
Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Signed-off-by: chaitali-mane <cmane@progress.com>
Copy link
Contributor

@himanshi-chhabra himanshi-chhabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants