-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Policy file details Page. #5327
Conversation
👷 Deploy Preview for chef-automate processing. 🔨 Explore the source changes: c54bbbc 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60f054bcb37f9d0007c4835f |
e5d2061
to
0245cea
Compare
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
0245cea
to
41fa74a
Compare
Hi @himanshi-chhabra , In Metadata label and text have more space. Can possible to make label text closer. |
components/automate-ui/src/app/entities/policy-files/policy-file.effects.ts
Show resolved
Hide resolved
...tomate-ui/src/app/modules/infra-proxy/policy-file-details/policy-file-details.component.html
Outdated
Show resolved
Hide resolved
...tomate-ui/src/app/modules/infra-proxy/policy-file-details/policy-file-details.component.scss
Outdated
Show resolved
Hide resolved
...tomate-ui/src/app/modules/infra-proxy/policy-file-details/policy-file-details.component.scss
Outdated
Show resolved
Hide resolved
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
@chaitali-mane Updated the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @himanshi-chhabra , Changes looks good
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Signed-off-by: Himanshi Chhabra hchhabra@progress.com
🔩 Description: What code changed, and why?
⛓️ Related Resources
#5244
#5245
👍 Definition of Done
👟 How to Build and Test the Change
PFA Video
To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps for policy file tab:
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
policy-file-detail.mp4