Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Policy file details Page. #5327

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Added Policy file details Page. #5327

merged 6 commits into from
Jul 21, 2021

Conversation

himanshi-chhabra
Copy link
Contributor

@himanshi-chhabra himanshi-chhabra commented Jul 9, 2021

Signed-off-by: Himanshi Chhabra hchhabra@progress.com

🔩 Description: What code changed, and why?

  • Add Policy details page
  • Added content tab
  • Added Included Policy locks and run list accordion.

⛓️ Related Resources

#5244
#5245

👍 Definition of Done

  • Added UI for the Policy details page.
  • Added UI for Policy file content tab
  • Added cypress test cases for the detail page.

👟 How to Build and Test the Change

PFA Video

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps for policy file tab:

  1. Go To Infrastructure -> Chef Servers -> click server name-> click on org name -> policyfile tab.
  2. Will see the policy file if available else will see no preview.
  3. if available click on policy file name -> will see details page
  4. click on Included Policy file accordion -> List of included Policy
  5. Click on Run list accordion -> will see list of run list

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

  1. Video for POlicy file details Page:
policy-file-detail.mp4
  1. No preview if we don't have included Policy.
    no_preview

@netlify
Copy link

netlify bot commented Jul 9, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: c54bbbc

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60f054bcb37f9d0007c4835f

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
@chaitali-mane
Copy link
Contributor

chaitali-mane commented Jul 13, 2021

Hi @himanshi-chhabra , In Metadata label and text have more space. Can possible to make label text closer.
Add letter spacing to header.
policy-metadata-err

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
@himanshi-chhabra
Copy link
Contributor Author

Hi @himanshi-chhabra , In Metadata label and text have more space. Can possible to make label text closer.
Add letter spacing to header.
policy-metadata-err

@chaitali-mane Updated the changes.
Also removed the space
policy-file

Copy link
Contributor

@chaitali-mane chaitali-mane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @himanshi-chhabra , Changes looks good

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 0f24e04 into master Jul 21, 2021
@kalroy kalroy deleted the Himanshi/policyfile_details branch July 21, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants