Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added sameSite_lax in cookie #5363

Merged
merged 2 commits into from
Jul 26, 2021
Merged

added sameSite_lax in cookie #5363

merged 2 commits into from
Jul 26, 2021

Conversation

iamazzeez
Copy link
Contributor

@iamazzeez iamazzeez commented Jul 16, 2021 •
edited
Loading

Fix for below issue

#4853

  • Added SameSite=Lax to cookie

To test

  • Pull changes from abdul/session_cookie
  • rebuild components/session-service
  • check for cookie SameSite flag in browser console -> Application -> Cookies -> session -> Check for sameSite flag is set to "Lax"

@iamazzeez iamazzeez requested a review from kalroy July 16, 2021 13:51
@iamazzeez iamazzeez self-assigned this Jul 16, 2021
@netlify
Copy link

netlify bot commented Jul 16, 2021 •
edited
Loading

✔️ Deploy Preview for chef-automate ready!

🔨 Explore the source changes: 49294bb

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60feb8c9e90dfc000793361f

😎 Browse the preview: https://deploy-preview-5363--chef-automate.netlify.app

@kalroy kalroy changed the title reduced cookie expiry and added sameSite_lax added sameSite_lax in cookie Jul 26, 2021
chaitali-mane
chaitali-mane approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@chaitali-mane chaitali-mane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kalroy
kalroy approved these changes Jul 26, 2021
View reviewed changes
Copy link
Collaborator

@kalroy kalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine!!

iamazzeez and others added 2 commits July 26, 2021 18:59
@iamazzeez
reduced cookie expiry and added sameSite_lax
dca77a6 
Signed-off-by: Abdul-Az <aazeez@progress.com>
@kalroy @iamazzeez
Removed Cookie expiry lifetime change
49294bb 
Signed-off-by: Kallol Roy <karoy@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit 9c6fff4 into master Jul 26, 2021
@kalroy kalroy deleted the abdul/session_cookie branch July 26, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitali-mane chaitali-mane chaitali-mane approved these changes

@kalroy kalroy kalroy approved these changes

@Venkatesh-rengasamy Venkatesh-rengasamy Awaiting requested review from Venkatesh-rengasamy

Assignees

@iamazzeez iamazzeez

Labels
acceptance: verified automate-auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamazzeez @kalroy @chaitali-mane