Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added revision id for policy file. #5377

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Added revision id for policy file. #5377

merged 3 commits into from
Jul 27, 2021

Conversation

himanshi-chhabra
Copy link
Contributor

Signed-off-by: Himanshi Chhabra hchhabra@progress.com

🔩 Description: What code changed, and why?

  • Add Revision Id list on policy file list page
  • Add slider panel component
  • Add Revision Id button on policy file details page

⛓️ Related Resources

#5242

👍 Definition of Done

  • Added UI for the revision id slider on the list and details page.
  • Added cypress test cases for the revision slider page.

👟 How to Build and Test the Change

PFA Video

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps for policy file tab:

  1. Go To Infrastructure -> Chef Servers -> click server name-> click on org name -> policyfile tab.
  2. Will see the policy file if available else will see no preview.
  3. if available click on policy file name -> click ... -> Revisions -> show list of revision if available
  4. if available click on policy file name -> will see details page -> click Revisions button-> show list of revision if available

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

revision-d.mp4

@netlify
Copy link

netlify bot commented Jul 23, 2021

✔️ Deploy Preview for chef-automate ready!

🔨 Explore the source changes: f6b5dbb

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/60ffb9f6df4a6100085cf5c1

😎 Browse the preview: https://deploy-preview-5377--chef-automate.netlify.app

Copy link
Collaborator

@vinay033 vinay033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link
Contributor

@chaitali-mane chaitali-mane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chnages Looks good, Thanks @himanshi-chhabra

Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
Signed-off-by: Himanshi Chhabra <hchhabra@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants