-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applications service API to get confirmation from UI after application service telemetry data is sent #6020
Merged
kalroy
merged 3 commits into
kallol/telemetry_improvements
from
Vinay/update_app_service_telemetry_last_reported_at
Oct 27, 2021
Merged
Applications service API to get confirmation from UI after application service telemetry data is sent #6020
kalroy
merged 3 commits into
kallol/telemetry_improvements
from
Vinay/update_app_service_telemetry_last_reported_at
Oct 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinay033
added
Team: Stalwart
Migrate Chef Manage, UI bugs, UX improvements, CVE Issues
telemetry
labels
Oct 26, 2021
kalroy
approved these changes
Oct 26, 2021
sonali523
force-pushed
the
kallol/telemetry_improvements
branch
from
October 27, 2021 05:33
f35babb
to
0d608a8
Compare
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: root <swale@msystechnologies.com>
sonali523
force-pushed
the
Vinay/update_app_service_telemetry_last_reported_at
branch
from
October 27, 2021 05:38
fbf3e45
to
02078b1
Compare
Kudos, SonarCloud Quality Gate passed! |
sonali523
approved these changes
Oct 27, 2021
kalroy
deleted the
Vinay/update_app_service_telemetry_last_reported_at
branch
October 27, 2021 06:55
sonali523
added a commit
that referenced
this pull request
Oct 29, 2021
…n service telemetry data is sent (#6020) * added API for update last reported application service telemetry date Signed-off-by: Vinay Sharma <vsharma@chef.io> * added some minor changes for comment Signed-off-by: Vinay Sharma <vsharma@chef.io> * Added some minor changes for comments Signed-off-by: root <swale@msystechnologies.com> Co-authored-by: root <swale@msystechnologies.com>
sonali523
added a commit
that referenced
this pull request
Nov 1, 2021
…n service telemetry data is sent (#6020) * added API for update last reported application service telemetry date Signed-off-by: Vinay Sharma <vsharma@chef.io> * added some minor changes for comment Signed-off-by: Vinay Sharma <vsharma@chef.io> * Added some minor changes for comments Signed-off-by: root <swale@msystechnologies.com> Co-authored-by: root <swale@msystechnologies.com>
sonali523
added a commit
that referenced
this pull request
Nov 8, 2021
…n service telemetry data is sent (#6020) * added API for update last reported application service telemetry date Signed-off-by: Vinay Sharma <vsharma@chef.io> * added some minor changes for comment Signed-off-by: Vinay Sharma <vsharma@chef.io> * Added some minor changes for comments Signed-off-by: root <swale@msystechnologies.com> Co-authored-by: root <swale@msystechnologies.com>
sonali523
added a commit
that referenced
this pull request
Nov 9, 2021
…n service telemetry data is sent (#6020) * added API for update last reported application service telemetry date Signed-off-by: Vinay Sharma <vsharma@chef.io> * added some minor changes for comment Signed-off-by: Vinay Sharma <vsharma@chef.io> * Added some minor changes for comments Signed-off-by: root <swale@msystechnologies.com> Co-authored-by: root <swale@msystechnologies.com>
sonali523
added a commit
that referenced
this pull request
Nov 10, 2021
…n service telemetry data is sent (#6020) * added API for update last reported application service telemetry date Signed-off-by: Vinay Sharma <vsharma@chef.io> * added some minor changes for comment Signed-off-by: Vinay Sharma <vsharma@chef.io> * Added some minor changes for comments Signed-off-by: root <swale@msystechnologies.com> Co-authored-by: root <swale@msystechnologies.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
acceptance: internal
Team: Stalwart
Migrate Chef Manage, UI bugs, UX improvements, CVE Issues
telemetry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vinay Sharma vsharma@chef.io
🔩 Description: What code changed, and why?
Automate application service API to get confirmation from UI after client run telemetry data is sent
⛓️ Related Resources
#5940
👍 Definition of Done
I have added the API in the application service to get confirmation from UI after application service telemetry data is sent
This API stores the last client run telemetry reported date after the telemetry data is sent
👟 How to Build and Test the Change
Steps to build:
Steps to test:
Request
This is a put request
curl -sSkH "api-token: $(get_admin_token)" 'https://a2-dev.test/api/v0/applications/telemetry/services/count/updated'
request body
Response
Saves the telemetry reported date in
telemetry
table ofchef_config_mgmt_service
database✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spell
in any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable