Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications service API to get confirmation from UI after application service telemetry data is sent #6020

Conversation

vinay033
Copy link
Collaborator

Signed-off-by: Vinay Sharma vsharma@chef.io

🔩 Description: What code changed, and why?

Automate application service API to get confirmation from UI after client run telemetry data is sent

⛓️ Related Resources

#5940

👍 Definition of Done

I have added the API in the application service to get confirmation from UI after application service telemetry data is sent
This API stores the last client run telemetry reported date after the telemetry data is sent

👟 How to Build and Test the Change

Steps to build:

rebuild components/automate-gateway
rebuild components/applications-service

Steps to test:

Request

This is a put request
curl -sSkH "api-token: $(get_admin_token)" 'https://a2-dev.test/api/v0/applications/telemetry/services/count/updated'

request body

{
    "lastTelemetryReportedAt":"2014-10-11T15:30:26.371Z"
}

Response

{}

Saves the telemetry reported date in telemetry table of chef_config_mgmt_service database

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@vinay033 vinay033 self-assigned this Oct 26, 2021
@vinay033 vinay033 added Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues telemetry labels Oct 26, 2021
@sonali523 sonali523 force-pushed the kallol/telemetry_improvements branch from f35babb to 0d608a8 Compare October 27, 2021 05:33
vinay033 and others added 3 commits October 27, 2021 11:06
Signed-off-by: Vinay Sharma <vsharma@chef.io>
Signed-off-by: root <swale@msystechnologies.com>
@sonali523 sonali523 force-pushed the Vinay/update_app_service_telemetry_last_reported_at branch from fbf3e45 to 02078b1 Compare October 27, 2021 05:38
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
22.5% 22.5% Duplication

@kalroy kalroy merged commit e910278 into kallol/telemetry_improvements Oct 27, 2021
@kalroy kalroy deleted the Vinay/update_app_service_telemetry_last_reported_at branch October 27, 2021 06:55
sonali523 added a commit that referenced this pull request Oct 29, 2021
…n service telemetry data is sent (#6020)

* added API for update last reported application service telemetry date

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes for comment

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* Added some minor changes for comments

Signed-off-by: root <swale@msystechnologies.com>

Co-authored-by: root <swale@msystechnologies.com>
sonali523 added a commit that referenced this pull request Nov 1, 2021
…n service telemetry data is sent (#6020)

* added API for update last reported application service telemetry date

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes for comment

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* Added some minor changes for comments

Signed-off-by: root <swale@msystechnologies.com>

Co-authored-by: root <swale@msystechnologies.com>
sonali523 added a commit that referenced this pull request Nov 8, 2021
…n service telemetry data is sent (#6020)

* added API for update last reported application service telemetry date

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes for comment

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* Added some minor changes for comments

Signed-off-by: root <swale@msystechnologies.com>

Co-authored-by: root <swale@msystechnologies.com>
sonali523 added a commit that referenced this pull request Nov 9, 2021
…n service telemetry data is sent (#6020)

* added API for update last reported application service telemetry date

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes for comment

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* Added some minor changes for comments

Signed-off-by: root <swale@msystechnologies.com>

Co-authored-by: root <swale@msystechnologies.com>
sonali523 added a commit that referenced this pull request Nov 10, 2021
…n service telemetry data is sent (#6020)

* added API for update last reported application service telemetry date

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* added some minor changes for comment

Signed-off-by: Vinay Sharma <vsharma@chef.io>

* Added some minor changes for comments

Signed-off-by: root <swale@msystechnologies.com>

Co-authored-by: root <swale@msystechnologies.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: internal Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants