Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open add new credential from scan job #6073

Merged

Conversation

shaik80
Copy link
Member

@shaik80 shaik80 commented Nov 9, 2021

Signed-off-by: shaik80 smudassi@progress.com

🔩 Description: What code changed, and why?

Through this Pr now it is possible to open add new credential from scan job

⛓️ Related Resources

#6069

👍 Definition of Done

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screen.Recording.2021-11-09.at.4.24.04.PM.mov

@netlify
Copy link

netlify bot commented Nov 9, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: d7b45c3

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/618a8f367ef81a00082c8050

Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🥳

@shaik80 shaik80 force-pushed the shaik-6069/Redirect_to_add_new_credentials_from_scan_job branch from 8e8b4bf to 5e71c25 Compare November 9, 2021 14:04
Signed-off-by: shaik80 <smudassi@progress.com>
@shaik80 shaik80 force-pushed the shaik-6069/Redirect_to_add_new_credentials_from_scan_job branch from 5e71c25 to d7b45c3 Compare November 9, 2021 15:09
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vivek-yadav vivek-yadav merged commit 25316e4 into main Nov 11, 2021
@vivek-yadav vivek-yadav deleted the shaik-6069/Redirect_to_add_new_credentials_from_scan_job branch November 11, 2021 17:19
@shaik80 shaik80 added acceptance: verified Team: S.H.I.E.L.D. This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories) labels Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified Team: S.H.I.E.L.D. This Label is used on S.H.I.E.L.D. Operations (Tasks / Stories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants