Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node count and detailed node run reports #6335

Merged
merged 6 commits into from
Dec 15, 2021
Merged

Conversation

kalroy
Copy link
Collaborator

@kalroy kalroy commented Dec 6, 2021

Signed-off-by: Kallol Roy karoy@progress.com

🔩 Description: What code changed, and why?

This PR adds a new cli option under license.
The usages are:

  • Get all the unique node counts running Chef Infra Client and reporting to Automate over a period of days
  • Get all the Infra Client node reports generated by Chef Infra Client and reporting to Automate over a period of days

⛓️ Related Resources

#6349

👍 Definition of Done

  • The cli outcome should have the location of the generated CSV
  • The CSV should give the details of the runs and nodes

👟 How to Build and Test the Change

hab studio enter
rebuild components/automate-cli
start_all_services
chef_load_nodes 500 // Load 500 nodes
chef-automate license uniqNodeRunReport -s 2021-12-06 -e 2021-12-08
chef-automate license nodeRunReport -s 2021-12-06 -e 2021-12-08 

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Dec 6, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: f78bbd2

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/61b93fdc8055af000847694f

@kalroy kalroy marked this pull request as draft December 6, 2021 06:24
@kalroy kalroy marked this pull request as ready for review December 8, 2021 14:42
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
Signed-off-by: Kallol Roy <karoy@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit 7d8f1ec into main Dec 15, 2021
@kalroy kalroy deleted the kallol/add_license_report branch December 15, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants