Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry coverage for Chef Infra Server Policy Groups tab #6797

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

Venkatesh-rengasamy
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy commented Mar 15, 2022

Signed-off-by: Venkatesh-rengasamy Venkatesh.Rengasamy@progress.com

🔩 Description: What code changed, and why?

Track the Infra-server policy-groups actions using telemetry track event.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-35

👍 Definition of Done

Infra-server policy-groups actions are tracked using telemetry track event.

👟 How to Build and Test the Change

inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

Steps for preview screen:
Go To Infrastructure -> Chef Servers -> Click on any Chef Infra Server -> Click on Orgs name -> select Policy Groups tab -> you can search, view policy-groups -> For each actions, you can observe the telemetry track event in Network tab(inspect the element window).

API URL - https://telemetry-acceptance.chef.io/events

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
@Venkatesh-rengasamy Venkatesh-rengasamy self-assigned this Mar 15, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy added telemetry Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues automate-ui automate-infra-proxy labels Mar 15, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy marked this pull request as ready for review March 15, 2022 11:00
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 6482b96 into main Mar 18, 2022
@kalroy kalroy deleted the venkatesh/KINETICS-35_Policy_Groups_telemetry branch March 18, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-infra-proxy automate-ui Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants