Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry Coverage for Notifications page under settings tab #6812

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

Venkatesh-rengasamy
Copy link
Contributor

@Venkatesh-rengasamy Venkatesh-rengasamy commented Mar 21, 2022

Signed-off-by: Venkatesh-rengasamy Venkatesh.Rengasamy@progress.com

🔩 Description: What code changed, and why?

Track the Notifications actions using telemetry track event.

⛓️ Related Resources

https://chefio.atlassian.net/browse/KINETICS-50

👍 Definition of Done

Notifications actions are tracked using telemetry track event.

👟 How to Build and Test the Change

inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

Steps for preview screen:
Go To Settings -> Notifications -> you can create, delete, view list of notifications -> For each actions, you can observe the telemetry track event in Network tab(inspect the element window).

API URL - https://telemetry-acceptance.chef.io/events

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Venkatesh-rengasamy <Venkatesh.Rengasamy@progress.com>
@netlify
Copy link

netlify bot commented Mar 21, 2022

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: c1d63ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/6238679a984db70008f427dc

@Venkatesh-rengasamy Venkatesh-rengasamy self-assigned this Mar 21, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy added Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues telemetry automate-ui labels Mar 21, 2022
@Venkatesh-rengasamy Venkatesh-rengasamy marked this pull request as ready for review March 21, 2022 11:57
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 220b576 into main Mar 22, 2022
@kalroy kalroy deleted the venkatesh/KINETICS-50_notifications_telemetry branch March 22, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-ui Team: Kinetic Analysis, user managerment, compliance size, govt findings, Telemetry, Customer bugs, CVE issues telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants