Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logrotate #7509

Merged
merged 12 commits into from
Nov 2, 2022
Merged

Logrotate #7509

merged 12 commits into from
Nov 2, 2022

Conversation

daveaugustus
Copy link
Contributor

@daveaugustus daveaugustus commented Oct 28, 2022

Signed-off-by: Pappu Kumar pappu.kumar@progress.com

🔩 Description: What code changed, and why?

The idea is to rotale log and allow the user to configure log rotate either daily, weekly or based on the log file size.

⛓️ Related Resources

👍 Definition of Done

  • User should be able to configure logrotate based on days, weeks...
  • Use should be able to configure logrotate based on size
  • Use should be able to keep last n log rotated files

👟 How to Build and Test the Change

rebuild components/automate-deployment

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Pappu Kumar added 2 commits October 28, 2022 19:50
cns
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@daveaugustus daveaugustus changed the title cns Logrotate Oct 28, 2022
@daveaugustus daveaugustus self-assigned this Oct 28, 2022
@daveaugustus daveaugustus marked this pull request as ready for review October 31, 2022 13:28
Pappu Kumar added 7 commits November 2, 2022 13:17
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Yashvi Jain and others added 3 commits November 2, 2022 16:00
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
@daveaugustus daveaugustus merged commit a722c15 into yashvi/STALWART-231 Nov 2, 2022
@daveaugustus daveaugustus deleted the dave/STALWART-232 branch November 2, 2022 17:03
@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
22.8% 22.8% Duplication

kalroy pushed a commit that referenced this pull request Nov 7, 2022
* Adding chamges for the config

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding functions for redirecting logs

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Logrotate (#7509)

* cns

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Logrotate setup

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PAtch changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* PAtch changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Added string conf

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Ran system command

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Added changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Final changes

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Removing unwanted loggers

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding correct combination for logrotate

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* logrotate

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Co-authored-by: Pappu Kumar <pappu.kumar@progress.com>
Co-authored-by: Yashvi Jain <yashvi.jain@progress.com>

* Changes for pipeline

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Uodated config logrotate

Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>

* Adding the config parameters

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Removing unwanted lines

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Changes for config request

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding compressed logic

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Adding the PR changes

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Pappu Kumar <pappu.kumar@progress.com>
Co-authored-by: Dave Augustus <36985548+daveaugustus@users.noreply.github.com>
Co-authored-by: Pappu Kumar <pappu.kumar@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants