Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support config set command from Automate HA Bastion Node #7670

Conversation

atultherajput
Copy link
Member

@atultherajput atultherajput commented Jan 18, 2023

Signed-off-by: Atul Krishna Atul.Krishna@progress.com

🔩 Description: What code changed, and why?

Added support config set command from Automate HA Bastion Node

⛓️ Related Resources

https://chefio.atlassian.net/browse/SHIELD-215

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2023-02-02 at 10 32 53 AM
Screenshot 2023-02-02 at 10 26 20 AM
Screenshot 2023-02-02 at 10 34 33 AM

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 7f9776d
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63dce18fde3b5400093b5e2c
😎 Deploy Preview https://deploy-preview-7670--chef-automate.netlify.app/automate/ha_config
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atultherajput atultherajput self-assigned this Jan 18, 2023
@atultherajput atultherajput marked this pull request as ready for review January 23, 2023 03:01
@atultherajput atultherajput requested a review from a team as a code owner January 24, 2023 10:22
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Jan 24, 2023
@atultherajput atultherajput force-pushed the SHIELD-215-support-config-set-command-from-automate-ha-bastion-node branch from c7facd3 to 7d8cc48 Compare January 24, 2023 10:54
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
Signed-off-by: Atul Krishna <Atul.Krishna@progress.com>
@atultherajput atultherajput force-pushed the SHIELD-215-support-config-set-command-from-automate-ha-bastion-node branch from e1341c4 to cada51e Compare February 2, 2023 05:55
atultherajput and others added 2 commits February 3, 2023 10:31
…ff-by: Atul Krishna <Atul.Krishna@progress.com>

Co-authored-by: vivekshankar1 <59958706+vivekshankar1@users.noreply.github.com>
Signed-off-by: dishanktiwari2501 <dtiwari@progress.com>
Copy link
Collaborator

@dishanktiwari2501 dishanktiwari2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the possible changes directly to the file.

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

35.1% 35.1% Coverage
4.1% 4.1% Duplication

@vivek-yadav vivek-yadav merged commit c319d42 into main Feb 6, 2023
@vivek-yadav vivek-yadav deleted the SHIELD-215-support-config-set-command-from-automate-ha-bastion-node branch February 6, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance: verified documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants