Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying file by buffer to protect the attack #7676

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Conversation

YashviJain01
Copy link
Collaborator

@YashviJain01 YashviJain01 commented Jan 19, 2023

Signed-off-by: Yashvi Jain yashvi.jain@progress.com

🔩 Description: What code changed, and why?

Logic added to copy zip file by bytes and not whole at a time, which can consume the memory of the system.

⛓️ Related Resources

https://chefio.atlassian.net/browse/IN-897

👍 Definition of Done

Now the file is being copied zip by zip

👟 How to Build and Test the Change

rebuild components/compliance_service

Upload a zip profile under upload profiles page

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
@netlify
Copy link

netlify bot commented Jan 19, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit 4c70c5d
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63c912013485390008ffc7f6

@YashviJain01 YashviJain01 marked this pull request as ready for review January 19, 2023 08:18
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kalroy kalroy merged commit b1a3f02 into main Jan 20, 2023
@kalroy kalroy deleted the yashvi/STALWART-313 branch January 20, 2023 07:32
shaik80 pushed a commit that referenced this pull request Jan 23, 2023
* Copying file by buffer to protect the attack

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Copying file by buffer to protect the attack

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Co-authored-by: Yashvi Jain <yashvi.jain@progress.com>
dishanktiwari2501 pushed a commit that referenced this pull request Jan 30, 2023
* Copying file by buffer to protect the attack

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

* Copying file by buffer to protect the attack

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Co-authored-by: Yashvi Jain <yashvi.jain@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants