Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the logic from 90 to one day #7704

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Changing the logic from 90 to one day #7704

merged 3 commits into from
Feb 6, 2023

Conversation

YashviJain01
Copy link
Collaborator

Signed-off-by: Yashvi Jain yashvi.jain@progress.com

🔩 Description: What code changed, and why?

Day latest will be mark for one day now rather than 90 days which is causing memory to shoot in opensearch 1.3.7

⛓️ Related Resources

https://chefio.atlassian.net/browse/STALWART-336

👍 Definition of Done

Day latest false is marked for yesterday only.

👟 How to Build and Test the Change

rebuild components/compliance-service/

Ingest the data in compliance service

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

@netlify
Copy link

netlify bot commented Feb 4, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 91cbdeb
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63e0d0f7195aaa0008ff1df6
😎 Deploy Preview https://deploy-preview-7704--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@YashviJain01 YashviJain01 requested a review from a team as a code owner February 6, 2023 07:04
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Feb 6, 2023
Yashvi Jain added 3 commits February 6, 2023 15:35
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
@kalroy kalroy merged commit 73b90e5 into main Feb 6, 2023
@kalroy kalroy deleted the yashvi/comp_fix branch February 6, 2023 10:28
@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants