Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue for the edit notification #7752

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

vinay033
Copy link
Collaborator

@vinay033 vinay033 commented Feb 27, 2023

🔩 Description: What code changed, and why?

As an Automate User, I can able to edit notification more than once.

⛓️ Related Resources

https://chefio.atlassian.net/browse/SHIELD-192

👍 Definition of Done

I have added some code changes for assigning a type to an object in case of the object is not loading with a specific type.

👟 How to Build and Test the Change

STEP 1
inside the hab studio

# build components/automate-ui-devproxy/
# start_automate_ui_background
# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab
--> need to click on settings tab -> on left side navigation click to notification --> create a new notification ---> you can see the list of notifications ---> click to any notification --> change the name or something else and click to save button.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

update_notification.webm

Signed-off-by: vinay sharma <vsharma@chef.io>
@netlify
Copy link

netlify bot commented Feb 27, 2023

👷 Deploy Preview for chef-automate processing.

Name Link
🔨 Latest commit e4077ec
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/63fcc579b768080007043918

@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 444779e into main Feb 28, 2023
@kalroy kalroy deleted the Vinay/fixed_edit_notification_issue branch February 28, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants