CHEF-727 : Version Command on Bastion #7970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for chef-automate processing.
|
shanmugapriya-tr
force-pushed
the
CHEF-727
branch
from
463fa9b
to
81635c8
Compare
shanmugapriya-tr
requested review from
vivek-yadav,
kalroy,
atultherajput,
daveaugustus,
punitmundra,
Dmaddu,
vivekshankar1,
prasad927,
YashviJain01,
rishabhjhs,
sandhi18 and
SahithiMy
| A2VERSIONVERBOSE = "sudo chef-automate version -v " | ||
| CSVERSIONCMD = "sudo chef-server-ctl version" | ||
| OSGETINFOCURLCMD = "curl -XGET http://localhost:10144" | ||
| PGGETVERSIONCURLCMD = "PGPASSWORD=%s hab pkg exec core/postgresql13 psql -U %s -h localhost -p 10145 -d postgres --dbname postgres -tAc 'SELECT version()'" |
There was a problem hiding this comment.
Can we have a version constant, what if the version gets changed in future, then this command will not work.
github-actions
bot
added
the
documentation
shanmugapriya-tr
force-pushed
the
CHEF-727
branch
from
8f680ef
to
17280ce
Compare
| @@ -91,8 +91,8 @@ func newDebugCmd() *cobra.Command { | |||
| logLevelCmd.Flags().StringVar(&logLevelCmdFlags.endpoint, "endpoint", "", "The endpoint the service is listening on") | |||
| logLevelCmd.Flags().DurationVar(&logLevelCmdFlags.connectionTimeout, "connection-timeout", 0, "Most time to wait to connect to service") | |||
|
|
|||
| versionCmd.Flags().StringVar(&versionCmdFlags.endpoint, "endpoint", "", "The endpoint the service is listening on") | |||
| versionCmd.Flags().DurationVar(&versionCmdFlags.connectionTimeout, "connection-timeout", 0, "Most time to wait to connect to service") | |||
| getVersionCmd.Flags().StringVar(&versionCmdFlags.endpoint, "endpoint", "", "The endpoint the service is listening on") | |||
There was a problem hiding this comment.
The flags were being set to the wrong versionCmd object, as a result of which, endpoint and connection timeout flags were coming up in docs under chef-automate version command. Corrected this
Dmaddu
requested changes
Jun 20, 2023
shanmugapriya-tr
force-pushed
the
CHEF-727
branch
2 times, most recently
from
6517bd4
to
c926234
Compare
daveaugustus
approved these changes
Jun 21, 2023
Dmaddu
requested changes
Jun 21, 2023
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
Signed-off-by: Shanmugapriya <shramana@progress.com>
shanmugapriya-tr
force-pushed
the
CHEF-727
branch
from
4ee06fd
to
961f37c
Compare
Dmaddu
approved these changes
Jun 21, 2023
YashviJain01
approved these changes
Jun 21, 2023
Dmaddu
requested changes
Jun 21, 2023
There was a problem hiding this comment.
https://buildkite.com/chef/chef-automate-main-verify-private/builds/29691
Pipelines are failing because of these changes only. Please address them
Signed-off-by: Shanmugapriya <shramana@progress.com>
|
SonarQube Quality Gate
|
Dmaddu
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Added code in version.go to enable bastion execution of the command chef-automate version
⛓️ Related Resources
https://chefio.atlassian.net/browse/CHEF-727
👍 Definition of Done
chef-automate version command should run from bastion and display the nodes versions
👟 How to Build and Test the Change
checkout this branch
build components/automate-cli
use the package to test
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
📷
Video Link : Click Here