Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support max shard configuration via patch #8048

Conversation

shaik80
Copy link
Member

@shaik80 shaik80 commented Jul 10, 2023

🔩 Description: What code changed, and why?

we need to support max_shard_per_node via patch command

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-3647

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Demo Video : max_shard_per_node.mp4

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit 0d8624e
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/64ba6fb73728920008b42558
😎 Deploy Preview https://deploy-preview-8048--chef-automate.netlify.app/automate/ha_config
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shaik80 shaik80 requested review from ArvinthC3000 and sandhi18 and removed request for ArvinthC3000 July 10, 2023 12:53
@shaik80 shaik80 requested a review from a team as a code owner July 12, 2023 05:42
@github-actions github-actions bot added the documentation Anything related to the Automate docs. label Jul 12, 2023
@shaik80 shaik80 changed the title [WIP] support max shard configuration via patch support max shard configuration via patch Jul 12, 2023
@shaik80 shaik80 requested review from a team, ArvinthC3000, vipin230 and bvtejaswi July 13, 2023 06:42
@shaik80 shaik80 changed the title support max shard configuration via patch [WIP] support max shard configuration via patch Jul 18, 2023
@shaik80 shaik80 force-pushed the CHEF-3647-max-shard-configuration-should-be-configurable-in-automate-ha-opensearch-config branch from 925bfeb to cc95bbd Compare July 21, 2023 11:43
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
Signed-off-by: shaik80 <shaik.mudassir@progress.com>
@shaik80 shaik80 force-pushed the CHEF-3647-max-shard-configuration-should-be-configurable-in-automate-ha-opensearch-config branch from cc95bbd to 0d8624e Compare July 21, 2023 11:44
@shaik80 shaik80 changed the title [WIP] support max shard configuration via patch support max shard configuration via patch Jul 21, 2023
@sonarqube-for-infrastructure-prod

@kalroy kalroy merged commit 90b5ae1 into main Jul 24, 2023
@kalroy kalroy deleted the CHEF-3647-max-shard-configuration-should-be-configurable-in-automate-ha-opensearch-config branch July 24, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the Automate docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants