Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to rotate OpenSearch password #8300

Merged
merged 7 commits into from
Nov 30, 2023
Merged

Changes to rotate OpenSearch password #8300

merged 7 commits into from
Nov 30, 2023

Conversation

jayvikramsharma1
Copy link
Collaborator

@jayvikramsharma1 jayvikramsharma1 commented Nov 23, 2023

🔩 Description: What code changed, and why?

As an Automate HA I want to rotate certificate of opensearch, as like same way I am able to rotate postgresql certificates

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-6522

Demo Video https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EW4Kir1KxdVPgcLLAlHVoSwBDOaY6Psm27hnIgRl7tZgFw?e=cEkhJ9

👍 Definition of Done

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Copy link

netlify bot commented Nov 23, 2023

Deploy Preview for chef-automate ready!

Name Link
🔨 Latest commit cd2cd4d
🔍 Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/65682eaf58008900087bf65d
😎 Deploy Preview https://deploy-preview-8300--chef-automate.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jayvikramsharma1 jayvikramsharma1 changed the title changes to rotate opensearch passowrkd [WIP] changes to rotate opensearch passoword Nov 23, 2023
@jayvikramsharma1 jayvikramsharma1 changed the title [WIP] changes to rotate opensearch passoword [WIP] changes to rotate OpenSearch password Nov 23, 2023
@jayvikramsharma1 jayvikramsharma1 changed the title [WIP] changes to rotate OpenSearch password [WIP] Changes to rotate OpenSearch password Nov 23, 2023
Copy link
Collaborator

@punitmundra punitmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please share the recorded video

  • do the rotation both the ways
    -- First auto password generation
    -- Get the password via user as well
    -- record the video for Postgres as well, with both the use case
    bump the package automate-backend-deployment as well

@jayvikramsharma1 jayvikramsharma1 changed the title [WIP] Changes to rotate OpenSearch password Changes to rotate OpenSearch password Nov 28, 2023
Copy link
Collaborator

@punitmundra punitmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump the automate backend deployment package for credentials.rb to use

Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
Signed-off-by: Jay Sharma <jsharma@progress.com>
@punitmundra punitmundra merged commit c61bcd4 into main Nov 30, 2023
3 of 7 checks passed
@punitmundra punitmundra deleted the jay/chef-6522 branch November 30, 2023 06:43

SonarQube Quality Gate

Quality Gate failed

Failed condition 0.0% 0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

anees-progress pushed a commit that referenced this pull request Nov 30, 2023
* changes to rotate opensearch passowrkd

Signed-off-by: Jay Sharma <jsharma@progress.com>

* changing roles file opensearch package

Signed-off-by: Jay Sharma <jsharma@progress.com>

* fixing role issue

Signed-off-by: Jay Sharma <jsharma@progress.com>

* in elasticsidecar.rb changing elasticsearch to opensearch in loggers

Signed-off-by: Jay Sharma <jsharma@progress.com>

* removing hard coded certificates

Signed-off-by: Jay Sharma <jsharma@progress.com>

* removing open distro from logs

Signed-off-by: Jay Sharma <jsharma@progress.com>

* changes in automate-backend-deployment for bump

Signed-off-by: Jay Sharma <jsharma@progress.com>

---------

Signed-off-by: Jay Sharma <jsharma@progress.com>
anees-progress pushed a commit that referenced this pull request Nov 30, 2023
* changes to rotate opensearch passowrkd

Signed-off-by: Jay Sharma <jsharma@progress.com>

* changing roles file opensearch package

Signed-off-by: Jay Sharma <jsharma@progress.com>

* fixing role issue

Signed-off-by: Jay Sharma <jsharma@progress.com>

* in elasticsidecar.rb changing elasticsearch to opensearch in loggers

Signed-off-by: Jay Sharma <jsharma@progress.com>

* removing hard coded certificates

Signed-off-by: Jay Sharma <jsharma@progress.com>

* removing open distro from logs

Signed-off-by: Jay Sharma <jsharma@progress.com>

* changes in automate-backend-deployment for bump

Signed-off-by: Jay Sharma <jsharma@progress.com>

---------

Signed-off-by: Jay Sharma <jsharma@progress.com>
swatiganesh pushed a commit that referenced this pull request Apr 16, 2024
* changes to rotate opensearch passowrkd

Signed-off-by: Jay Sharma <jsharma@progress.com>

* changing roles file opensearch package

Signed-off-by: Jay Sharma <jsharma@progress.com>

* fixing role issue

Signed-off-by: Jay Sharma <jsharma@progress.com>

* in elasticsidecar.rb changing elasticsearch to opensearch in loggers

Signed-off-by: Jay Sharma <jsharma@progress.com>

* removing hard coded certificates

Signed-off-by: Jay Sharma <jsharma@progress.com>

* removing open distro from logs

Signed-off-by: Jay Sharma <jsharma@progress.com>

* changes in automate-backend-deployment for bump

Signed-off-by: Jay Sharma <jsharma@progress.com>

---------

Signed-off-by: Jay Sharma <jsharma@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants