New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgraded to github.com/nats-io/nats-server/v2@v2.9.23 #8423

Merged

Dmaddu merged 41 commits into main from aishu/6795

May 3, 2024

Collaborator

Aishwarya2001A commented Apr 15, 2024 •

edited by kparmar2000

Loading

🔩 Description: What code changed, and why?

upgraded github.com/nats-io/nats-server/v2 version => 2.9.23

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-6795

👍 Definition of Done

changed nats server to version 2.9.23 with which few of the other package on which nats-server was dependent was added. So, we had to add licenses for transitive dependencies too.

👟 How to Build and Test the Change

✅ Checklist

All PRs must tick these:

I have read the CONTRIBUTING document.
All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

Tests added/updated? (all new code needs new tests)
Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

Screenshot 2024-05-02 at 5 27 44 PM

https://progresssoftware-my.sharepoint.com/personal/kparmar_progress_com/_layouts/15/stream.aspx?id=%2Fpersonal%2Fkparmar%5Fprogress%5Fcom%2FDocuments%2Fnats%5Fserver%2Ewebm&referrer=StreamWebApp%2EWeb&referrerScenario=AddressBarCopied%2Eview%2E5c6cf698%2Df495%2D4608%2Db3b0%2D81fd752bdf61


          upgraded to github.com/nats-io/nats-server/v2@v2.9.23

655cb2e

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

netlify bot commented Apr 15, 2024 •

edited

Loading

👷 Deploy Preview for chef-automate processing.

Name	Link
🔨 Latest commit	`4a4b707`
🔍 Latest deploy log	https://app.netlify.com/sites/chef-automate/deploys/663486d11f5c9c00087172c0

Aishwarya2001A and others added 28 commits

April 16, 2024 09:40


          pushing code after running go mod tidy

9c6e2c5

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding licence in license_acout,moving jwt to v2 and package changes …

a08d11b

…in event-gateway and event-service

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          fixing build error in authenticator.go

a13a022

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding replace in mod file

63f8b05

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          major changes in event-gateway and event serice and solving pipeline:…

fe64814

…license scout

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          solving pipeline:license scout

ea019d3

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding license to go.uber.org/automaxprocs

740da1f

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding go.uber.org/automaxprocs in go.mod

fe1711f

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding go.uber.org/automaxprocs in license scout for checking other c…

57f9205

…omponents

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          removing go.uber.org/automaxprocs from exceptions

da985ae

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          solving pipelines

a750d1e

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          solving pipelines

49ec6df

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          solving pipelines

a753a89

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding go.uber.org/automaxprocs@latest in go.mod

2f7e3d9

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          making nat-server as indirect in go.mod

063bfa4

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          changes

0c169ae

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding licence

4edc5d8

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          commenting go mod verify

b687450

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding replace in go.mod and exceptions in license scout

5d82bb2

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          changes

13667ec

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding include_subdirectories

6a5e420

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          alignment

70bb389

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          adding exceptions

b01a64b

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          removing exceptions

9251ccc

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>


          license scout chnaged with flagged licenses

381f945


          making automaxproc as direct dependency

c96739c


          Revert "license scout chnaged with flagged licenses"

26bee76

This reverts commit 381f945.


          made direct deppendency for automaxprocs

50a4b22

Signed-off-by: karan parmar <kparmar@progress.com>

kparmar2000 force-pushed the aishu/6795 branch from f077887 to 237c171 Compare

April 30, 2024 05:40


          made direct dependency for automaxprocs 2

ae2d920

Signed-off-by: karan parmar <kparmar@progress.com>

kparmar2000 force-pushed the aishu/6795 branch from 237c171 to ae2d920 Compare

April 30, 2024 06:05

kparmar2000 added 7 commits

April 30, 2024 14:43


          license added in license scout

070e5ac

Signed-off-by: karan parmar <kparmar@progress.com>


          package added

56b1637

Signed-off-by: karan parmar <kparmar@progress.com>


          changes in license_scout

0705c2e

Signed-off-by: karan parmar <kparmar@progress.com>


          changed license scout

fc095c6

Signed-off-by: karan parmar <kparmar@progress.com>


          added prashantv package to direct dependency

96ff648

Signed-off-by: karan parmar <kparmar@progress.com>


          added prashantv package to direct dependency

f946267

Signed-off-by: karan parmar <kparmar@progress.com>


          license removed for prashntv

03d7e86

Signed-off-by: karan parmar <kparmar@progress.com>

kparmar2000 marked this pull request as ready for review

May 2, 2024 11:59

kparmar2000 requested a review from Dmaddu

May 2, 2024 11:59

Dmaddu requested changes

View reviewed changes

components/event-gateway/pkg/nats/check.go Outdated Show resolved Hide resolved

components/event-gateway/pkg/nats/server.go Outdated Show resolved Hide resolved

components/event-gateway/pkg/nats/tls_test.go Outdated Show resolved Hide resolved

components/event-service/nats/server.go Outdated Show resolved Hide resolved

components/event-service/nats/server.go Outdated Show resolved Hide resolved

components/event-service/nats/server.go Outdated Show resolved Hide resolved

components/event-service/nats/server.go Outdated Show resolved Hide resolved

components/event-gateway/pkg/nats/server.go Outdated Show resolved Hide resolved


          goroutine has been added

e231cb5

Signed-off-by: karan parmar <kparmar@progress.com>

Dmaddu requested changes

View reviewed changes

components/event-service/nats/server.go Outdated Show resolved Hide resolved

.license_scout.yml Outdated Show resolved Hide resolved

components/event-gateway/pkg/nats/server.go Outdated Show resolved Hide resolved

components/event-service/nats/server.go Outdated Show resolved Hide resolved

components/event-service/nats/server.go Outdated Show resolved Hide resolved


          review changes

5ff50ea

Signed-off-by: karan parmar <kparmar@progress.com>

kparmar2000 force-pushed the aishu/6795 branch from de41057 to 5ff50ea Compare

May 3, 2024 05:41

kparmar2000 added 2 commits

May 3, 2024 12:01


          review changes 2

22f29ca

Signed-off-by: karan parmar <kparmar@progress.com>


          review changes 2

4a4b707

Signed-off-by: karan parmar <kparmar@progress.com>

sonarqube-for-infrastructure-prod bot commented May 3, 2024

SonarQube Quality Gate

0.0% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

Dmaddu approved these changes

View reviewed changes

Dmaddu merged commit 3ca13c6 into main

10 of 13 checks passed

Dmaddu deleted the aishu/6795 branch

May 3, 2024 18:19

kalroy pushed a commit that referenced this pull request


          upgraded to github.com/nats-io/nats-server/v2@v2.9.23 (#8423)

c019784

* upgraded to github.com/nats-io/nats-server/v2@v2.9.23

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* pushing code after running go mod tidy

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding licence in license_acout,moving jwt to v2 and package changes in event-gateway and event-service

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* fixing build error in authenticator.go

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding replace in mod file

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* major changes in event-gateway and event serice and solving pipeline:license scout

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* solving pipeline:license scout

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding license to go.uber.org/automaxprocs

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding go.uber.org/automaxprocs in go.mod

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding go.uber.org/automaxprocs in license scout for checking other components

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* removing go.uber.org/automaxprocs from exceptions

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* solving pipelines

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* solving pipelines

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* solving pipelines

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding go.uber.org/automaxprocs@latest in go.mod

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* making nat-server as indirect in go.mod

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* changes

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding licence

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* commenting go mod verify

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding replace in go.mod and exceptions in license scout

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* changes

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding include_subdirectories

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* alignment

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* adding exceptions

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* removing exceptions

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>

* license scout chnaged with flagged licenses

* making automaxproc as direct dependency

* Revert "license scout chnaged with flagged licenses"

This reverts commit 381f945.

* made direct deppendency for automaxprocs

Signed-off-by: karan parmar <kparmar@progress.com>

* made direct dependency for automaxprocs 2

Signed-off-by: karan parmar <kparmar@progress.com>

* license added in license scout

Signed-off-by: karan parmar <kparmar@progress.com>

* package added

Signed-off-by: karan parmar <kparmar@progress.com>

* changes in license_scout

Signed-off-by: karan parmar <kparmar@progress.com>

* changed license scout

Signed-off-by: karan parmar <kparmar@progress.com>

* added prashantv package to direct dependency

Signed-off-by: karan parmar <kparmar@progress.com>

* added prashantv package to direct dependency

Signed-off-by: karan parmar <kparmar@progress.com>

* license removed for prashntv

Signed-off-by: karan parmar <kparmar@progress.com>

* goroutine has been added

Signed-off-by: karan parmar <kparmar@progress.com>

* review changes

Signed-off-by: karan parmar <kparmar@progress.com>

* review changes 2

Signed-off-by: karan parmar <kparmar@progress.com>

* review changes 2

Signed-off-by: karan parmar <kparmar@progress.com>

---------

Signed-off-by: Aishwarya Aishwarya <aaishwar@progress.com>
Signed-off-by: karan parmar <kparmar@progress.com>
Co-authored-by: karan parmar <kparmar@progress.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet