[pg-gateway] Set server-fin timeout #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a go process dies because of a signal or a panic, defer'd database closes may not execute. In this case, HAProxy will keep the client side connection in CLOSE-WAIT and the server-side connection in ESTAB. Setting `server-fin` times out the server-side connection quickly, avoiding a leaked process. Without this, the process would not close for 5 minutes until the tunnel timeout is hit. Signed-off-by: Steven Danna <steve@chef.io>
srenatus
approved these changes
Jul 11, 2019
| # a service is failing in a loop, this can quickly lead to the | ||
| # exhaustion of available ports. | ||
| # | ||
| # This number was chosen with very little thought. |
I can't think of a compelling reason to keep these connections around any longer than we need to since the postgresql shutdown procedure is: > The normal, graceful termination procedure is that the frontend sends a Terminate message and immediately closes the connection. On receipt of this message, the backend closes the connection and terminates. So the server is expecting an immediate close from the client once it has sent a Terminate and the server doesn't typically send a response. Signed-off-by: Steven Danna <steve@chef.io>
srenatus
approved these changes
Jul 11, 2019
jaym
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a go process dies because of a signal or a panic, defer'd
database closes may not execute. In this case, HAProxy will keep the
client side connection in CLOSE-WAIT and the server-side connection in
ESTAB. Setting
server-fintimes out the server-side connectionquickly, avoiding a leaked process. Without this, the process would
not close for 5 minutes until the tunnel timeout is hit.
Signed-off-by: Steven Danna steve@chef.io