Revert DRY-ing up of datamigrations that introduced bug #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit https://github.com/chef/automate/blob/c94572e5ab3cfbaec2230af0afdfde7e0bfff145/components/authz-service/storage/postgres/datamigration/datamigration.go accidentally removed some Reset code that was special to datamigrations. This code resets the data_migrations table when reset to IAM v1 so that on the next upgrade to 2.x the datamigrations get reapplied. This is different than standard migrations since we never undo schema migrations. Signed-off-by: Tyler Cloke <tylercloke@gmail.com>
this test ensures that after resetting to v1 and then upgrading to v2.1 again, authorization works as expected on v2.1 Signed-off-by: Brenna Hewer-Darroch <brenna@chef.io> Signed-off-by: Tyler Cloke <tylercloke@gmail.com> Signed-off-by: Blake Johnson <bstier@chef.io>
msorens
approved these changes
Jul 10, 2019
bcmdarroch
approved these changes
Jul 10, 2019
Signed-off-by: Tyler Cloke <tylercloke@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description
This change accidentally removed some Reset code that was special to datamigrations. This code resets the data_migrations table when reset to IAM v1 so that on the next upgrade to 2.x the datamigrations get reapplied. This is different than standard migrations since we never undo schema migrations.
Also added regression tests to the pipeline.
✅ Checklist